starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Use get_queryset functions when using valid_models to force re-evaluation #11481

New Issue
Closed
opened 2025-12-29 21:45:50 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:45:50 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Aug 14, 2025).

Originally assigned to: @arthanson on GitHub.

Proposed Changes

The code currently defines queryset using valid_models as class variables like the following:

class ObjectChangeListView(generic.ObjectListView):
    queryset = ObjectChange.objects.valid_models()

instead define these as get_queryset functions that return ObjectChange.objects.valid_models()

Justification

valid_models creates a set of content types and then returns a filtered list of ObjectTypes. The problem is that when defined as class variables this is only done when the class is instantiated and not when requested, so any potential changes to ContentTypes after instantiation is not picked up.

Originally created by @arthanson on GitHub (Aug 14, 2025). Originally assigned to: @arthanson on GitHub. ### Proposed Changes The code currently defines queryset using valid_models as class variables like the following: ``` class ObjectChangeListView(generic.ObjectListView): queryset = ObjectChange.objects.valid_models() ``` instead define these as get_queryset functions that return `ObjectChange.objects.valid_models()` ### Justification valid_models creates a set of content types and then returns a filtered list of ObjectTypes. The problem is that when defined as class variables this is only done when the class is instantiated and not when requested, so any potential changes to ContentTypes after instantiation is not picked up.
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:45:50 +01:00
adam closed this issue 2025-12-29 21:45:50 +01:00
adam commented 2025-12-29 21:45:51 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 14, 2025):

Reclassifying this as a feature request

@jeremystretch commented on GitHub (Aug 14, 2025): Reclassifying this as a feature request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?