starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Configurable choices for FHRP Groups #11474

New Issue
Closed
opened 2025-12-29 21:45:43 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:45:43 +01:00
Owner
Copy Link

Originally created by @Larster05 on GitHub (Aug 12, 2025).

NetBox version

v4.3.3

Feature type

Change to existing functionality

Proposed functionality

Adding custom choices to the FHRP Groups protocol field like it got added to the status fields in v3.2.
Link to Request for the mentioned feature in v3.2:
https://github.com/netbox-community/netbox/issues/8054

Use case

Current or future FHRP Protocols (like HPEs VSX Active Gateway, Aristas virtual-ip) could be added by the user and must not be included in the general model.

Database changes

Change of current FHRP Groups protocol field.

External dependencies

No response

Originally created by @Larster05 on GitHub (Aug 12, 2025). ### NetBox version v4.3.3 ### Feature type Change to existing functionality ### Proposed functionality Adding custom choices to the FHRP Groups protocol field like it got added to the status fields in v3.2. Link to Request for the mentioned feature in v3.2: https://github.com/netbox-community/netbox/issues/8054 ### Use case Current or future FHRP Protocols (like HPEs VSX Active Gateway, Aristas virtual-ip) could be added by the user and must not be included in the general model. ### Database changes Change of current FHRP Groups protocol field. ### External dependencies _No response_
adam added the type: featurestatus: under review labels 2025-12-29 21:45:43 +01:00
adam closed this issue 2025-12-29 21:45:43 +01:00
adam commented 2025-12-29 21:45:43 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 14, 2025):

Why not just add the desired protocols to the list? So long as they're reasonably documented we can add them to NetBox, and save other users the hassle of needing to redefine them.

@jeremystretch commented on GitHub (Aug 14, 2025): Why not just add the desired protocols to the list? So long as they're reasonably documented we can add them to NetBox, and save other users the hassle of needing to redefine them.
adam commented 2025-12-29 21:45:44 +01:00
Author
Owner
Copy Link

@Larster05 commented on GitHub (Aug 15, 2025):

Hi, thanks for the fast reply.

Than I would like to add three new protocols to the FHRP Protocol Choice (FHRPGroupProtocolChoices):

For a better overview it would also be nice to move the "Other" option into a Other group, so it wouldn't just be shown within the last group in the drop-down menu.

To implement those additions the following code needs to be added to class FHRPGroupProtocolChoices within netbox/ipam/choices.py:

    ...
    PROTOCOL_AAG = 'aag'
    PROTOCOL_AVARP = 'avarp'
    PROTOCOL_PAHA = 'paha'
    ...
    CHOICES = (
        ...
        (_('Aruba'), (
            (PROTOCOL_AAG, 'Active-Gateway'),
        )),
        (_('Arista'), (
            (PROTOCOL_AVARP, 'VARP'),
        )),
        (_('Palo Alto'), (
            (PROTOCOL_PAHA, 'HA-Cluster'),
        )),
        (_('Other'), (
            (PROTOCOL_OTHER, 'Other'),
        )),
    )
@Larster05 commented on GitHub (Aug 15, 2025): Hi, thanks for the fast reply. Than I would like to add three new protocols to the FHRP Protocol Choice (FHRPGroupProtocolChoices): - Aruba: Active-Gateway (https://arubanetworking.hpe.com/techdocs/AOS-CX/10.05/HTML/5200-7283/index.html#GUID-846E330D-39CE-4E50-B8F6-589375211680.html) - Arista: VARP (https://www.arista.com/en/um-eos/eos-vrrp-and-varp#xx1152758) - Palo Alto: HA-Cluster (https://docs.paloaltonetworks.com/pan-os/10-1/pan-os-admin/high-availability/ha-overview) For a better overview it would also be nice to move the "Other" option into a Other group, so it wouldn't just be shown within the last group in the drop-down menu. To implement those additions the following code needs to be added to class `FHRPGroupProtocolChoices` within `netbox/ipam/choices.py`: ``` ... PROTOCOL_AAG = 'aag' PROTOCOL_AVARP = 'avarp' PROTOCOL_PAHA = 'paha' ... CHOICES = ( ... (_('Aruba'), ( (PROTOCOL_AAG, 'Active-Gateway'), )), (_('Arista'), ( (PROTOCOL_AVARP, 'VARP'), )), (_('Palo Alto'), ( (PROTOCOL_PAHA, 'HA-Cluster'), )), (_('Other'), ( (PROTOCOL_OTHER, 'Other'), )), ) ```
adam commented 2025-12-29 21:45:44 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 6, 2025):

Can't find much on this, but this seems to be a fancy name for EVPN Anycast Gateway (similar to below)

This is not really an FHRP, it is a fancy name for EVPN Anycast Gateway

This is not a real FHRP, while we do have a Cluster option for FHRP for checkpoint, and we could likely add more, perhaps a more generic name would be better

@DanSheps commented on GitHub (Sep 6, 2025): > * Aruba: Active-Gateway (https://arubanetworking.hpe.com/techdocs/AOS-CX/10.05/HTML/5200-7283/index.html#GUID-846E330D-39CE-4E50-B8F6-589375211680.html) Can't find much on this, but this seems to be a fancy name for EVPN Anycast Gateway (similar to below) > * Arista: VARP (https://www.arista.com/en/um-eos/eos-vrrp-and-varp#xx1152758) This is not really an FHRP, it is a fancy name for EVPN Anycast Gateway > * Palo Alto: HA-Cluster (https://docs.paloaltonetworks.com/pan-os/10-1/pan-os-admin/high-availability/ha-overview) This is not a real FHRP, while we do have a Cluster option for FHRP for checkpoint, and we could likely add more, perhaps a more generic name would be better
adam commented 2025-12-29 21:45:44 +01:00
Author
Owner
Copy Link

@Larster05 commented on GitHub (Sep 19, 2025):

Hello,

I see your point regarding Aruba and Arista.
Regarding the mentioned HA-Custer would it be possible to just add it like described?

Generic:
      HA-Custer
      Other
@Larster05 commented on GitHub (Sep 19, 2025): Hello, I see your point regarding Aruba and Arista. Regarding the mentioned HA-Custer would it be possible to just add it like described? ``` Generic: HA-Custer Other ```
adam commented 2025-12-29 21:45:44 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Oct 2, 2025):

FHRP groups in NetBox are meant to model first-hop redundancy protocols (wire protocols where multiple devices share an IP). Palo Alto HA is device-level failover, not an FHRP.

The correct option here is to use the existing "Other" option.

@jnovinger commented on GitHub (Oct 2, 2025): FHRP groups in NetBox are meant to model first-hop redundancy protocols (wire protocols where multiple devices share an IP). Palo Alto HA is device-level failover, not an FHRP. The correct option here is to use the existing "Other" option.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: under review type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?