Unique device role #11351

New Issue

adam · 2025-12-29T21:44:04+01:00

adam commented

2025-12-29 21:44:04 +01:00

Originally created by @Crubumble on GitHub (Jul 8, 2025).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.3.3

Python Version

3.10

Steps to Reproduce

Add a new device role (/dcim/device-roles/add/) named "Building Automation"
Add a further device role named "camera" with "Build Automation" as parent
Add a further device role named "camera" with "Build Automation" as parent
Add a further device role named "camera" with no parent

Expected Behavior

Creating a device role with the same hierarchy and name (and description) should not be possible.
Therefore, only the device role created under step 1,2 and 4 should be possible.

Observed Behavior

All device roles were created.
Device roles are created even if the same role exists already.

Originally created by @Crubumble on GitHub (Jul 8, 2025). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.3.3 ### Python Version 3.10 ### Steps to Reproduce 1. Add a new device role (/dcim/device-roles/add/) named "Building Automation" 2. Add a further device role named "camera" with "Build Automation" as parent 3. Add a further device role named "camera" with "Build Automation" as parent 4. Add a further device role named "camera" with no parent ### Expected Behavior Creating a device role with the same hierarchy and name (and description) should not be possible. Therefore, only the device role created under step 1,2 and 4 should be possible. ### Observed Behavior All device roles were created. Device roles are created even if the same role exists already.

adam added the type: bug status: accepted severity: medium labels 2025-12-29 21:44:04 +01:00

adam closed this issue

2025-12-29 21:44:04 +01:00

adam commented

2025-12-29 21:44:04 +01:00

@jeremystretch commented on GitHub (Jul 8, 2025):

Your report above is very confusing: You appear to be conflating multiple issues in a single report.

Please revise your report above to capture a single, specific issue, and open separate bug reports for any other concerns.

@jeremystretch commented on GitHub (Jul 8, 2025): Your report above is very confusing: You appear to be conflating multiple issues in a single report. Please revise your report above to capture a single, specific issue, and open separate bug reports for any other concerns.

adam commented

2025-12-29 21:44:05 +01:00

@Crubumble commented on GitHub (Jul 9, 2025):

@jeremystretch Sorry for the confusion. I revised the post.

@Crubumble commented on GitHub (Jul 9, 2025): @jeremystretch Sorry for the confusion. I revised the post.

adam commented

2025-12-29 21:44:05 +01:00

@sleepinggenius2 commented on GitHub (Jul 9, 2025):

It looks like when DeviceRole was moved from an OrganizationalModel to a NestedGroupModel in 4.3, the previous unique constraints on name and slug were not transitioned. I believe these constraints just need to be added under DeviceRole.Meta:

constraints = (
    models.UniqueConstraint(
        fields=('parent', 'name'),
        name='%(app_label)s_%(class)s_parent_name'
    ),
    models.UniqueConstraint(
        fields=('name',),
        name='%(app_label)s_%(class)s_name',
        condition=Q(parent__isnull=True),
        violation_error_message=_("A top-level device role with this name already exists.")
    ),
    models.UniqueConstraint(
        fields=('parent', 'slug'),
        name='%(app_label)s_%(class)s_parent_slug'
    ),
    models.UniqueConstraint(
        fields=('slug',),
        name='%(app_label)s_%(class)s_slug',
        condition=Q(parent__isnull=True),
        violation_error_message=_("A top-level device role with this slug already exists.")
    ),
)

@sleepinggenius2 commented on GitHub (Jul 9, 2025): It looks like when `DeviceRole` was moved from an `OrganizationalModel` to a `NestedGroupModel` in 4.3, the previous unique constraints on `name` and `slug` were not transitioned. I believe these constraints just need to be added under `DeviceRole.Meta`: ```python constraints = ( models.UniqueConstraint( fields=('parent', 'name'), name='%(app_label)s_%(class)s_parent_name' ), models.UniqueConstraint( fields=('name',), name='%(app_label)s_%(class)s_name', condition=Q(parent__isnull=True), violation_error_message=_("A top-level device role with this name already exists.") ), models.UniqueConstraint( fields=('parent', 'slug'), name='%(app_label)s_%(class)s_parent_slug' ), models.UniqueConstraint( fields=('slug',), name='%(app_label)s_%(class)s_slug', condition=Q(parent__isnull=True), violation_error_message=_("A top-level device role with this slug already exists.") ), ) ```

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#11351