starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Show duplicates IP in another colour for shared role #1131

New Issue
Closed
opened 2025-12-29 16:29:16 +01:00 by adam · 1 comment
adam commented 2025-12-29 16:29:16 +01:00
Owner
Copy Link

Originally created by @claudex on GitHub (Jul 26, 2017).

Issue type: feature request

With the new IP role added (thanks for that), would it be possible to change the duplication check when displaying an IP ? I would like to show the warning in another colour the duplicate addresses if the role is to be shared among several interface (VIP, anycast, VRRP...). I still think that it is usefull to show the other duplicate IP to see where it is allocated.

Here is an exemple of what I think. If you think this is OK, I will work on a pull request with cleaner code.

(code in ipadress.html)

        {% if duplicate_ips_table.rows %}
                        {% if ipaddress.get_role_display == 'VIP' %}
                                {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='info' %}
                        {% else %}
                                {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='danger' %}
                        {% endif %}
        {% endif %}
Originally created by @claudex on GitHub (Jul 26, 2017). ### Issue type: feature request With the new IP role added (thanks for that), would it be possible to change the duplication check when displaying an IP ? I would like to show the warning in another colour the duplicate addresses if the role is to be shared among several interface (VIP, anycast, VRRP...). I still think that it is usefull to show the other duplicate IP to see where it is allocated. Here is an exemple of what I think. If you think this is OK, I will work on a pull request with cleaner code. (code in ipadress.html) ~~~ {% if duplicate_ips_table.rows %} {% if ipaddress.get_role_display == 'VIP' %} {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='info' %} {% else %} {% include 'panel_table.html' with table=duplicate_ips_table heading='Duplicate IP Addresses' panel_class='danger' %} {% endif %} {% endif %} ~~~
adam closed this issue 2025-12-29 16:29:16 +01:00
adam commented 2025-12-29 16:29:17 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Aug 30, 2017):

I think it makes sense to simply ignore duplicate IPs with the "anycast" role, but for the rest of these you still want to know when you have duplicate IPs. For instance, you should typically only have one VRRP IP in a prefix, which is shared by multiple devices. (Note that we cannot currently map a VIP explicitly to multiple interfaces, though we'll probably implement something in the future.)

@jeremystretch commented on GitHub (Aug 30, 2017): I think it makes sense to simply ignore duplicate IPs with the "anycast" role, but for the rest of these you still want to know when you have duplicate IPs. For instance, you should typically only have one VRRP IP in a prefix, which is shared by multiple devices. (Note that we cannot currently map a VIP explicitly to multiple interfaces, though we'll probably implement something in the future.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?