IPAM FilterSet: filter_present_in_vrf method returns queryset.none instead of calling it when VRF is None #11274

New Issue

adam · 2025-12-29T21:42:45+01:00

adam commented

2025-12-29 21:42:45 +01:00

Originally created by @pheus on GitHub (Jun 6, 2025).

Originally assigned to: @pheus on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.3.2

Python Version

3.11

Steps to Reproduce

Launch the NetBox shell:
```
python3 manage.py nbshell
```

Run the following:

from ipam.models import IPAddress
from ipam.filtersets import IPAddressFilterSet

qs = IPAddress.objects.all()
filterset = IPAddressFilterSet()

# Intentionally passing `None` as the `vrf` parameter
result = filterset.filter_present_in_vrf(qs, 'present_in_vrf', None)
print(result)

Observe the result when vrf is None.

Expected Behavior

When vrf is None, the method should return an empty queryset like:

<RestrictedQuerySet []>

Observed Behavior

The method instead returns a method reference:

<bound method QuerySet.none of <RestrictedQuerySet [...]>>

This happens because queryset.none is returned without being called - i.e., it's missing parentheses. This causes unexpected behavior when the return value is used downstream, potentially leading to runtime issues or incorrect query evaluation.

2680f855ff/netbox/ipam/filtersets.py (L449-L456)

2680f855ff/netbox/ipam/filtersets.py (L730-L736)

Originally created by @pheus on GitHub (Jun 6, 2025). Originally assigned to: @pheus on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.3.2 ### Python Version 3.11 ### Steps to Reproduce 1. Launch the NetBox shell: ```bash python3 manage.py nbshell ``` 2. Run the following: ```python from ipam.models import IPAddress from ipam.filtersets import IPAddressFilterSet qs = IPAddress.objects.all() filterset = IPAddressFilterSet() # Intentionally passing `None` as the `vrf` parameter result = filterset.filter_present_in_vrf(qs, 'present_in_vrf', None) print(result) ``` 3. Observe the result when `vrf` is `None`. ### Expected Behavior When `vrf` is `None`, the method should return an **empty queryset** like: ```python <RestrictedQuerySet []> ``` ### Observed Behavior The method instead returns a **method reference**: ```python <bound method QuerySet.none of <RestrictedQuerySet [...]>> ``` This happens because `queryset.none` is returned without being called - i.e., it's missing parentheses. This causes unexpected behavior when the return value is used downstream, potentially leading to runtime issues or incorrect query evaluation. https://github.com/netbox-community/netbox/blob/2680f855ffaef0a876bac811d4cd56198ae3f329/netbox/ipam/filtersets.py#L449-L456 https://github.com/netbox-community/netbox/blob/2680f855ffaef0a876bac811d4cd56198ae3f329/netbox/ipam/filtersets.py#L730-L736

adam added the type: bug status: accepted severity: low labels 2025-12-29 21:42:45 +01:00

adam closed this issue

2025-12-29 21:42:45 +01:00

adam commented

2025-12-29 21:42:46 +01:00

@pheus commented on GitHub (Jun 6, 2025):

I'd be happy to submit a fix for this.

@pheus commented on GitHub (Jun 6, 2025): I'd be happy to submit a fix for this.

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#11274

IPAM FilterSet: filter_present_in_vrf method returns queryset.none instead of calling it when VRF is None #11274