starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Atomic transactions go to default database by default #11259

New Issue
Closed
opened 2025-12-29 21:42:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:42:35 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Jun 4, 2025).

Originally assigned to: @arthanson on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.3.1

Python Version

3.12

Steps to Reproduce

This is linked to the branching issue (https://github.com/netboxlabs/netbox-branching/issues/271)

  1. Create and activate new branch.
  2. Select IPAM-> prefixes and bulk import
  3. put your bulk import data.
  4. In the middle of data make a mistake that the import would fail (lets say define wrong VRF)
    The same applies to some other objects where name/item uniqueness is not being checked (VRFs, Chassis and etc.).

Data set for import

prefix;status;vrf;vlan_group
192.168.100.0/22;active;abc;mygroup1
10.113.128.128/29;active;dbc;mygroup1
10.116.0.129/29;active;efg;mygroup1
10.1.29.0/24;active;ghj;mygroup1

Before you try this import:

  • make sure you have VLAN group "mygroup1" existing.
  • make sure you have all VRFs existing.
  • Make sure all prefixes do NOT exist.

When I try to do import in such conditions, I get following error:

Record 3 prefix: 10.116.0.129/29 is not a valid prefix. Did you mean 10.116.0.128/29?
But problem is that import for record 1 and 2 was still performed.

The root issue here is we are doing with transaction.atomic() which is always going to the default branch so the rollback in the case of errors is not working correctly.

Expected Behavior

None of the data should imported if there are any errors on data.

Observed Behavior

  • If the main branch is used then import failure behaves properly: none of data was imported

  • If doing that on any other branch:
    Data up to the the failing line is imported.
    Error where the failure occurred is shown for short time and then disappears.
    It is not clear which part of data import was successful (especially if you miss that error popup).
    If you try to load data again you get duplicate records (in this case prefixes) again till the failing line.

Originally created by @arthanson on GitHub (Jun 4, 2025). Originally assigned to: @arthanson on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.3.1 ### Python Version 3.12 ### Steps to Reproduce This is linked to the branching issue (https://github.com/netboxlabs/netbox-branching/issues/271) 1. Create and activate new branch. 2. Select IPAM-> prefixes and bulk import 3. put your bulk import data. 4. In the middle of data make a mistake that the import would fail (lets say define wrong VRF) The same applies to some other objects where name/item uniqueness is not being checked (VRFs, Chassis and etc.). **Data set for import** prefix;status;vrf;vlan_group 192.168.100.0/22;active;abc;mygroup1 10.113.128.128/29;active;dbc;mygroup1 10.116.0.129/29;active;efg;mygroup1 10.1.29.0/24;active;ghj;mygroup1 **Before you try this import:** - make sure you have VLAN group "mygroup1" existing. - make sure you have all VRFs existing. - Make sure all prefixes do **NOT** exist. **When I try to do import in such conditions, I get following error:** ```Record 3 prefix: 10.116.0.129/29 is not a valid prefix. Did you mean 10.116.0.128/29?``` But problem is that import for record 1 and 2 was still performed. The root issue here is we are doing `with transaction.atomic()` which is always going to the default branch so the rollback in the case of errors is not working correctly. ### Expected Behavior None of the data should imported if there are any errors on data. ### Observed Behavior - If the main branch is used then import failure behaves properly: none of data was imported - If doing that on any other branch: Data up to the the failing line is imported. Error where the failure occurred is shown for short time and then disappears. It is not clear which part of data import was successful (especially if you miss that error popup). If you try to load data again you get duplicate records (in this case prefixes) again till the failing line.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:42:35 +01:00
adam closed this issue 2025-12-29 21:42:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?