starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Changing an existing device in a rack that will "bump" into another device doesn't error #11230

New Issue
Closed
opened 2025-12-29 21:42:14 +01:00 by adam · 7 comments
adam commented 2025-12-29 21:42:14 +01:00
Owner
Copy Link

Originally created by @ckdarby on GitHub (May 28, 2025).

Deployment Type

NetBox Cloud (Used the Netbox demo)

NetBox Version

v4.3.1

Python Version

3.10

Steps to Reproduce

  1. Have a rack
  2. Put a device above
  3. Create a 1U device below
  4. Try to change 1U device to 2U device

No error is presented even though save button allows action to happen.

Example, modify optical patch from 1u to 2u device:
Image

Expected Behavior

Expected the 2U to take up the available space below OR to communicate to the user this action isn't possible.

Observed Behavior

No error is presented and just left on the save form.

Originally created by @ckdarby on GitHub (May 28, 2025). ### Deployment Type NetBox Cloud (Used the Netbox demo) ### NetBox Version v4.3.1 ### Python Version 3.10 ### Steps to Reproduce 1. Have a rack 2. Put a device above 3. Create a 1U device below 4. Try to change 1U device to 2U device No error is presented even though save button allows action to happen. Example, modify optical patch from 1u to 2u device: ![Image](https://github.com/user-attachments/assets/323ddb4f-4959-47fc-8c15-867eb11b8254) ### Expected Behavior Expected the 2U to take up the available space below OR to communicate to the user this action isn't possible. ### Observed Behavior No error is presented and just left on the save form.
adam added the type: bugpending closurestatus: revisions needed labels 2025-12-29 21:42:14 +01:00
adam closed this issue 2025-12-29 21:42:15 +01:00
adam commented 2025-12-29 21:42:15 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (May 28, 2025):

@ckdarby where are you modifying the height (what menu items are you going to)? I'm not seeing this, I added a device as you said in step 1-3 with a device-type that had a 1U size, then I go to the device type and change it to 2U and I do get an error (see below). Or are you trying to edit it somewhere else? This is NetBox v4.3.1

Image

@arthanson commented on GitHub (May 28, 2025): @ckdarby where are you modifying the height (what menu items are you going to)? I'm not seeing this, I added a device as you said in step 1-3 with a device-type that had a 1U size, then I go to the device type and change it to 2U and I do get an error (see below). Or are you trying to edit it somewhere else? This is NetBox v4.3.1 ![Image](https://github.com/user-attachments/assets/8961e907-7a01-4a29-9d08-95b4f21414fa)
adam commented 2025-12-29 21:42:16 +01:00
Author
Owner
Copy Link

@ckdarby commented on GitHub (May 28, 2025):

From this edit button

Image

@ckdarby commented on GitHub (May 28, 2025): From this edit button ![Image](https://github.com/user-attachments/assets/2785f8c5-47cf-4af7-ab8b-c08d36f520a7)
adam commented 2025-12-29 21:42:16 +01:00
Author
Owner
Copy Link

@ckdarby commented on GitHub (May 28, 2025):

I should have clarified that I am not modifying the device itself but changing the device type from 1U to 2U.

In that edit page I am changing the type from APC Optical Patch Panel 8 type in the edit to 48-patch panel (2U).

@ckdarby commented on GitHub (May 28, 2025): I should have clarified that I am not modifying the device itself but changing the device type from 1U to 2U. In that edit page I am changing the type from APC Optical Patch Panel 8 type in the edit to 48-patch panel (2U).
adam commented 2025-12-29 21:42:16 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (May 28, 2025):

@ckdarby I am still not seeing that, I used a device with a device type with 1U in the rack, I then edit the device and change it to a device type with a 2U and I get an error:

Image

@arthanson commented on GitHub (May 28, 2025): @ckdarby I am still not seeing that, I used a device with a device type with 1U in the rack, I then edit the device and change it to a device type with a 2U and I get an error: ![Image](https://github.com/user-attachments/assets/63bc9af8-d10c-499a-a981-5283a9b08b00)
adam commented 2025-12-29 21:42:17 +01:00
Author
Owner
Copy Link

@ckdarby commented on GitHub (May 29, 2025):

@arthanson Confirmed on my side. This would likely be more of an enhancement than a bug at this point.

As a new user, this is what I see when I change the type and click save
Image

There’s no user feedback indicating an error on the modified field. When I return to the page, my change to '48-Port Patch Panel' still appears, so it’s not immediately clear anything went wrong. The error only becomes visible when I scroll down to an unrelated field I didn't modify, which could be confusing and counterintuitive for users.

This leads to some discussions:

  • Should errors be displayed at the top combined given?
  • Should clicking save with a failure not return to the prior state?
  • Should modifying the device still not simply shift the unit space down, as it is available?
@ckdarby commented on GitHub (May 29, 2025): @arthanson Confirmed on my side. This would likely be more of an enhancement than a bug at this point. As a new user, this is what I see when I change the type and click save ![Image](https://github.com/user-attachments/assets/1bc34d2d-8347-4b7c-b7a6-46de2ea3b248) There’s no user feedback indicating an error on the modified field. When I return to the page, my change to '48-Port Patch Panel' still appears, so it’s not immediately clear anything went wrong. The error only becomes visible when I scroll down to an unrelated field I didn't modify, which could be confusing and counterintuitive for users. This leads to some discussions: - Should errors be displayed at the top combined given? - Should clicking save with a failure not return to the prior state? - Should modifying the device still not simply shift the unit space down, as it is available?
adam commented 2025-12-29 21:42:17 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jun 6, 2025):

This is a reminder that additional information is needed in order to further triage this issue. If the requested details are not provided, the issue will soon be closed automatically.

@github-actions[bot] commented on GitHub (Jun 6, 2025): This is a reminder that additional information is needed in order to further triage this issue. If the requested details are not provided, the issue will soon be closed automatically.
adam commented 2025-12-29 21:42:17 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jun 13, 2025):

This issue is being closed as no further information has been provided. If you would like to revisit this topic, please first modify your original post to include all the requested detail, and then ask that the issue be reopened.

@github-actions[bot] commented on GitHub (Jun 13, 2025): This issue is being closed as no further information has been provided. If you would like to revisit this topic, please first modify your original post to include all the requested detail, and then ask that the issue be reopened.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure status: revisions needed type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?