starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

DeviceSerializer should use a proper serializer for its parent device #1123

New Issue
Closed
opened 2025-12-29 16:29:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 16:29:13 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jul 25, 2017).

Issue type: Bug Report

Python version: 2.7.6
NetBox version: 2.0.10

The DeviceSerializer currently uses a custom SerializerMethodField to return information about a device's parent device:

    def get_parent_device(self, obj):
        try:
            device_bay = obj.parent_bay
        except DeviceBay.DoesNotExist:
            return None
        return {
            'id': device_bay.device.pk,
            'name': device_bay.device.name,
            'device_bay': {
                'id': device_bay.pk,
                'name': device_bay.name,
            }
        }

This should be replaced with a proper serializer and include a URL to the related object.

Originally created by @jeremystretch on GitHub (Jul 25, 2017). ### Issue type: Bug Report **Python version:** 2.7.6 **NetBox version:** 2.0.10 The DeviceSerializer currently uses a custom SerializerMethodField to return information about a device's parent device: ``` def get_parent_device(self, obj): try: device_bay = obj.parent_bay except DeviceBay.DoesNotExist: return None return { 'id': device_bay.device.pk, 'name': device_bay.device.name, 'device_bay': { 'id': device_bay.pk, 'name': device_bay.name, } } ``` This should be replaced with a proper serializer and include a URL to the related object.
adam added the type: bug label 2025-12-29 16:29:13 +01:00
adam closed this issue 2025-12-29 16:29:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?