starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove Duplicate IP Range API Serializer Values #11124

New Issue
Closed
opened 2025-12-29 21:40:38 +01:00 by adam · 4 comments
adam commented 2025-12-29 21:40:38 +01:00
Owner
Copy Link

Originally created by @mr1716 on GitHub (May 5, 2025).

Originally assigned to: @mr1716 on GitHub.

Proposed Changes

Image

When doing some custom development for my own Netbox instance, I found that there may be some duplicate IP Range API Serializers

Justification

Removing Duplicates values

Originally created by @mr1716 on GitHub (May 5, 2025). Originally assigned to: @mr1716 on GitHub. ### Proposed Changes ![Image](https://github.com/user-attachments/assets/2cb5d249-d6b0-453b-8001-9af13df63a4a) When doing some custom development for my own Netbox instance, I found that there may be some duplicate IP Range API Serializers ### Justification Removing Duplicates values
adam added the status: acceptedtype: housekeeping labels 2025-12-29 21:40:38 +01:00
adam closed this issue 2025-12-29 21:40:38 +01:00
adam commented 2025-12-29 21:40:39 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (May 5, 2025):

Hey @mr1716 , it doesn't look like this causes custom_fields to be duplicated in REST API responses. But, you are absolutely correct that it doesn't need to be there twice. Thanks for the report!

@jnovinger commented on GitHub (May 5, 2025): Hey @mr1716 , it doesn't look like this causes `custom_fields` to be duplicated in REST API responses. But, you are absolutely correct that it doesn't need to be there twice. Thanks for the report!
adam commented 2025-12-29 21:40:40 +01:00
Author
Owner
Copy Link

@mr1716 commented on GitHub (May 5, 2025):

@jnovinger understood. Thanks. I'll take care of this ticket and have a PR shortly

@mr1716 commented on GitHub (May 5, 2025): @jnovinger understood. Thanks. I'll take care of this ticket and have a PR shortly
adam commented 2025-12-29 21:40:40 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (May 5, 2025):

@mr1716 , I did also notice that there are other duplicates in there, besides just custom_fields. I couldn't tell if you had seen them as well from the screenshot.

@jnovinger commented on GitHub (May 5, 2025): @mr1716 , I did also notice that there are other duplicates in there, besides just `custom_fields`. I couldn't tell if you had seen them as well from the screenshot.
adam commented 2025-12-29 21:40:40 +01:00
Author
Owner
Copy Link

@mr1716 commented on GitHub (May 5, 2025):

@jnovinger thanks. I did, but highlighted that 1 field to be simple

@mr1716 commented on GitHub (May 5, 2025): @jnovinger thanks. I did, but highlighted that 1 field to be simple
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11124
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?