starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Redirect URLs are not sanitized in some cases #11093

New Issue
Closed
opened 2025-12-29 21:40:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:40:14 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 28, 2025).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.8

Python Version

3.10

Steps to Reproduce

There are a few instances where NetBox returns a redirect crafted from the URL specified in a request. For instance:

81dfaf0d67/netbox/dcim/views.py (L3797)

Expected Behavior

These values should be validated using Django's url_has_allowed_host_and_scheme() function prior to use.

Observed Behavior

These values are passed directly to the HTTP response object.

Originally created by @jeremystretch on GitHub (Apr 28, 2025). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.8 ### Python Version 3.10 ### Steps to Reproduce There are a few instances where NetBox returns a redirect crafted from the URL specified in a request. For instance: https://github.com/netbox-community/netbox/blob/81dfaf0d6769ffc732a7e073135eb0f99f694e21/netbox/dcim/views.py#L3797 ### Expected Behavior These values should be validated using Django's `url_has_allowed_host_and_scheme()` function prior to use. ### Observed Behavior These values are passed directly to the HTTP response object.
adam added the type: bugstatus: acceptedseverity: medium labels 2025-12-29 21:40:14 +01:00
adam closed this issue 2025-12-29 21:40:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11093
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?