starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Edit and Delete Buttons for mark_populated IPRange on ListView Link to IPAddress Instead of IPRange #11063

New Issue
Closed
opened 2025-12-29 21:39:47 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:39:47 +01:00
Owner
Copy Link

Originally created by @pheus on GitHub (Apr 22, 2025).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.3.0-beta1

Python Version

3.10

Steps to Reproduce

  1. Create a Prefix 192.168.0.0/22
  2. Create an IP Range 192.168.1.50-99/22 with:
    • Start: 192.168.1.50/22
    • End: 192.168.1.99/22
    • mark_populated: True
  3. Navigate to the Prefix 192.168.0.0/22 → IP Addresses tab
  4. Locate the row representing the populated IPRange
  5. Click either the Edit or Delete button next to 192.168.1.50-99/22

Expected Behavior

Both Edit and Delete should operate on the IPRange object and bring up the appropriate forms for modifying or deleting the range.

Observed Behavior

Both buttons incorrectly operate on an IPAddress object, using the ID of the IPRange.

Impact:

  • Attempting to edit/delete an IPRange actually opens the form for a different object (an IPAddress).
  • This creates confusion and may result in unintended modifications or deletion of unrelated IPAddresses.

Additional Notes:

  • This seems to affect only populated IPRanges (mark_populated=True).
  • The Edit action is being misrouted, possibly due to a rendering issue or mistaken object type association in the IP Address list view.
Originally created by @pheus on GitHub (Apr 22, 2025). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.3.0-beta1 ### Python Version 3.10 ### Steps to Reproduce 1. Create a Prefix `192.168.0.0/22` 2. Create an IP Range `192.168.1.50-99/22` with: - Start: `192.168.1.50/22` - End: `192.168.1.99/22` - `mark_populated`: **True** 3. Navigate to the Prefix `192.168.0.0/22` → *IP Addresses* tab 4. Locate the row representing the populated IPRange 5. Click either the **Edit** or **Delete** button next to `192.168.1.50-99/22` ### Expected Behavior Both **Edit** and **Delete** should operate on the IPRange object and bring up the appropriate forms for modifying or deleting the range. ### Observed Behavior Both buttons incorrectly operate on an **IPAddress** object, using the ID of the IPRange. **Impact:** - Attempting to edit/delete an IPRange actually opens the form for a different object (an IPAddress). - This creates confusion and may result in unintended modifications or deletion of unrelated IPAddresses. **Additional Notes:** - This seems to affect only populated IPRanges (`mark_populated=True`). - The Edit action is being misrouted, possibly due to a rendering issue or mistaken object type association in the IP Address list view.
adam added the type: bugstatus: acceptedbetaseverity: medium labels 2025-12-29 21:39:47 +01:00
adam closed this issue 2025-12-29 21:39:47 +01:00
adam commented 2025-12-29 21:39:48 +01:00
Author
Owner
Copy Link

@pheus commented on GitHub (Apr 22, 2025):

Update:
This issue also affects the Delete button for populated IP Ranges (mark_populated=True).
Clicking Delete opens the confirmation dialog for an IPAddress object, not the IPRange.

So both Edit and Delete actions are misrouted in the IP Addresses list view when dealing with populated IPRanges.

I've updated the issue title and description to reflect that.
Thanks in advance for taking a look!

@pheus commented on GitHub (Apr 22, 2025): **Update:** This issue also affects the **Delete** button for populated IP Ranges (`mark_populated=True`). Clicking **Delete** opens the confirmation dialog for an **IPAddress** object, not the IPRange. So both **Edit** and **Delete** actions are misrouted in the *IP Addresses* list view when dealing with populated IPRanges. I've updated the issue title and description to reflect that. Thanks in advance for taking a look!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label beta severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11063
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?