starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Language cookie should respect SESSION_COOKIE_SECURE value #11030

New Issue
Closed
opened 2025-12-29 21:39:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:39:21 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Apr 15, 2025).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.7

Python Version

3.10

Steps to Reproduce

N/A

Expected Behavior

When a cookie is set (here, for instance) indicating the user's preferred language, it should be marked as "secure" if SESSION_COOKIE_SECURE is True (the same as the session cookie).

Observed Behavior

The language cookie is always set with secure=False (the default).

Originally created by @jeremystretch on GitHub (Apr 15, 2025). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.7 ### Python Version 3.10 ### Steps to Reproduce N/A ### Expected Behavior When a cookie is set ([here](https://github.com/netbox-community/netbox/blob/70cc7c7563fa5923b543d2faad6dbb2d1823f109/netbox/netbox/middleware.py#L46), for instance) indicating the user's preferred language, it should be marked as "secure" if `SESSION_COOKIE_SECURE` is True (the same as the session cookie). ### Observed Behavior The language cookie is always set with `secure=False` (the default).
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:39:21 +01:00
adam closed this issue 2025-12-29 21:39:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#11030
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?