starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow VirtualMachine and Device filter by IP address from Primary IP #10996

New Issue
Closed
opened 2025-12-29 21:38:58 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:38:58 +01:00
Owner
Copy Link

Originally created by @miaow2 on GitHub (Apr 8, 2025).

Originally assigned to: @miaow2 on GitHub.

NetBox version

v4.2.6

Feature type

New functionality

Proposed functionality

Add primary_ip4 and primary_ip6 filters to ipam.filtersets.PrimaryIPFilterSet

Use case

In our use cases we need to get virtual machine or device by their primary IP. Now we do this in two requests:

  1. find IP address id by api/ipam/ip-addresses/?address=1.1.1.1/32
  2. find device or VM by filtering api/dcim/devices/?primary_ip4_id=<ip_id>

I propose to add filtering by IP address directly, so users can do it only in one request: api/dcim/devices/?primary_ip4=1.1.1.1/32. This will decrease the number of requests and time to complete.

If the issue is accepted, I would be glad to submit a PR.

Database changes

None

External dependencies

None

Originally created by @miaow2 on GitHub (Apr 8, 2025). Originally assigned to: @miaow2 on GitHub. ### NetBox version v4.2.6 ### Feature type New functionality ### Proposed functionality Add `primary_ip4` and `primary_ip6` filters to `ipam.filtersets.PrimaryIPFilterSet` ### Use case In our use cases we need to get virtual machine or device by their primary IP. Now we do this in two requests: 1. find IP address id by `api/ipam/ip-addresses/?address=1.1.1.1/32` 2. find device or VM by filtering `api/dcim/devices/?primary_ip4_id=<ip_id>` I propose to add filtering by IP address directly, so users can do it only in one request: `api/dcim/devices/?primary_ip4=1.1.1.1/32`. This will decrease the number of requests and time to complete. If the issue is accepted, I would be glad to submit a PR. ### Database changes None ### External dependencies None
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:38:58 +01:00
adam closed this issue 2025-12-29 21:38:58 +01:00
adam commented 2025-12-29 21:38:58 +01:00
Author
Owner
Copy Link

@bctiemann commented on GitHub (Apr 8, 2025):

This sounds like a good add. Thanks @miaow2 !

@bctiemann commented on GitHub (Apr 8, 2025): This sounds like a good add. Thanks @miaow2 !
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10996
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?