starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove querystring template tag #10989

New Issue
Open
opened 2025-12-29 21:38:50 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:38:50 +01:00
Owner
Copy Link

Originally created by @alehaa on GitHub (Apr 6, 2025).

NetBox version

v4.2.6

Feature type

Change to existing functionality

Proposed functionality

With Django 5.1 a built-in querystring template tag is available. I suggest removing the custom implementation in favor of the built-in one.

Use case

The built-in template tag doesn't need the request parameter. This can cause confusion when importing the helpers module into a template (e.g. for a custom plugin) which overrides the built-in template tag.

Database changes

None

External dependencies

None

Originally created by @alehaa on GitHub (Apr 6, 2025). ### NetBox version v4.2.6 ### Feature type Change to existing functionality ### Proposed functionality With [Django 5.1](https://docs.djangoproject.com/en/5.1/ref/templates/builtins/#querystring) a built-in `querystring` template tag is available. I suggest removing the custom implementation in favor of the built-in one. ### Use case The built-in template tag doesn't need the `request` parameter. This can cause confusion when importing the `helpers` module into a template (e.g. for a custom plugin) which overrides the built-in template tag. ### Database changes None ### External dependencies None
adam added the type: featurenetboxstatus: backlogcomplexity: low labels 2025-12-29 21:38:50 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low netbox status: backlog type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?