GraphQL: Querying for Manufacturer on Inventory-Items leads to nun-null error #10946

New Issue

adam · 2025-12-29T21:38:10+01:00

adam commented

2025-12-29 21:38:10 +01:00

Originally created by @dxks on GitHub (Mar 25, 2025).

Originally assigned to: @jnovinger on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.5

Python Version

3.10

Steps to Reproduce

Reproducable on demo.netbox.dev. Also on v4.2.6 in our environment

Create a Inventory-Item on any device and leave the manufacturer blank (as it is not required
Query the following graph-ql (with the specific device-id):

query {
  device(id:172) {id name inventoryitems {id name manufacturer{id name}}}
}

Expected Behavior

Output of Device with given Inventory-Items and manufacturer to be null (i.e. like if tenant is not set):

{
  "data": {
    "device": {
      "id": "172",
      "name": "0634LEO",
      "inventoryitems": [
        {
          "id": "1",
          "name": "Test",
          "manufacturer": null
        }
      ]
    }
  }
}

Observed Behavior

Error raised that manufacturer cannot be null:

{
  "data": null,
  "errors": [
    {
      "message": "Cannot return null for non-nullable field InventoryItemType.manufacturer.",
      "locations": [
        {
          "line": 2,
          "column": 68
        }
      ],
      "path": [
        "device",
        "inventoryitems",
        0,
        "manufacturer"
      ]
    }
  ]
}

Originally created by @dxks on GitHub (Mar 25, 2025). Originally assigned to: @jnovinger on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.5 ### Python Version 3.10 ### Steps to Reproduce Reproducable on demo.netbox.dev. Also on v4.2.6 in our environment 1. Create a Inventory-Item on any device and leave the manufacturer blank (as it is not required 2. Query the following graph-ql (with the specific device-id): ``` query { device(id:172) {id name inventoryitems {id name manufacturer{id name}}} } ``` ### Expected Behavior Output of Device with given Inventory-Items and manufacturer to be null (i.e. like if tenant is not set): ``` { "data": { "device": { "id": "172", "name": "0634LEO", "inventoryitems": [ { "id": "1", "name": "Test", "manufacturer": null } ] } } } ``` ### Observed Behavior Error raised that manufacturer cannot be null: ``` { "data": null, "errors": [ { "message": "Cannot return null for non-nullable field InventoryItemType.manufacturer.", "locations": [ { "line": 2, "column": 68 } ], "path": [ "device", "inventoryitems", 0, "manufacturer" ] } ] } ```

adam added the type: bug status: accepted topic: GraphQL severity: low labels 2025-12-29 21:38:10 +01:00

adam closed this issue

2025-12-29 21:38:11 +01:00

adam referenced this issue

2025-12-29 23:20:26 +01:00

[PR #10947] [MERGED] Fixes #10946 - Check that device has a platform set before rendering napalm tab #13721

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#10946