starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Treatment of kind field on JournalEntry is inconsistent #10873

New Issue
Closed
opened 2025-12-29 21:37:06 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:37:06 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Mar 11, 2025).

Originally assigned to: @jeremystretch on GitHub.

Deployment Type

NetBox Cloud

NetBox Version

v4.2.5

Python Version

3.10

Steps to Reproduce

  1. View a site and click the "Journal" tab.
  2. Add a journal entry without specifying a kind.

Expected Behavior

The kind field should always be required (AFAICT):

class JournalEntry(...):
    kind = models.CharField(
        verbose_name=_('kind'),
        max_length=30,
        choices=JournalEntryKindChoices,
        default=JournalEntryKindChoices.KIND_INFO
    )

Observed Behavior

The kind field is not required by either the model's form or its REST API serializer.

class JournalEntryForm(NetBoxModelForm):
    kind = forms.ChoiceField(
        label=_('Kind'),
        choices=add_blank_choice(JournalEntryKindChoices),
        required=False
    )

class JournalEntrySerializer(NetBoxModelSerializer):
    kind = ChoiceField(
        choices=JournalEntryKindChoices,
        required=False
    )
Originally created by @jeremystretch on GitHub (Mar 11, 2025). Originally assigned to: @jeremystretch on GitHub. ### Deployment Type NetBox Cloud ### NetBox Version v4.2.5 ### Python Version 3.10 ### Steps to Reproduce 1. View a site and click the "Journal" tab. 2. Add a journal entry without specifying a kind. ### Expected Behavior The `kind` field should always be required (AFAICT): ```python class JournalEntry(...): kind = models.CharField( verbose_name=_('kind'), max_length=30, choices=JournalEntryKindChoices, default=JournalEntryKindChoices.KIND_INFO ) ``` ### Observed Behavior The `kind` field is not required by either the model's form or its REST API serializer. ```python class JournalEntryForm(NetBoxModelForm): kind = forms.ChoiceField( label=_('Kind'), choices=add_blank_choice(JournalEntryKindChoices), required=False ) ``` ```python class JournalEntrySerializer(NetBoxModelSerializer): kind = ChoiceField( choices=JournalEntryKindChoices, required=False ) ```
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:37:06 +01:00
adam closed this issue 2025-12-29 21:37:06 +01:00
adam commented 2025-12-29 21:37:07 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 13, 2025):

When a journal entry is created via the REST API, its kind defaults to info if not specified, which is expected. The REST API will not permit kind to be empty or null.

However, a journal entry created via the web form can be created with no kind. This needs to be corrected in the form.

@jeremystretch commented on GitHub (Mar 13, 2025): When a journal entry is created via the REST API, its `kind` defaults to info if not specified, which is expected. The REST API will not permit `kind` to be empty or null. However, a journal entry created via the web form can be created with no kind. This needs to be corrected in the form.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10873
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?