starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Local Context Data can be set to non-none falsy values #10859

New Issue
Closed
opened 2025-12-29 21:36:50 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:36:50 +01:00
Owner
Copy Link

Originally created by @fabi125 on GitHub (Mar 7, 2025).

Originally assigned to: @fabi125 on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.5

Python Version

3.10

Steps to Reproduce

  1. Edit a device in the UI (e.g. https://demo.netbox.dev/dcim/devices/37/)
  2. Put in 0 as the local config context and save.

Expected Behavior

Change gets rejected for not being correct JSON (like it does for any other flat values).
Config Context also correctly rejects 0 or "" values.

Observed Behavior

Change is accepted.

Image

Relevant code: https://github.com/netbox-community/netbox/blame/v4.2.5/netbox/extras/models/configs.py#L202-L206

Happy to put up a PR for this.

Originally created by @fabi125 on GitHub (Mar 7, 2025). Originally assigned to: @fabi125 on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.5 ### Python Version 3.10 ### Steps to Reproduce 1. Edit a device in the UI (e.g. https://demo.netbox.dev/dcim/devices/37/) 2. Put in 0 as the local config context and save. ### Expected Behavior Change gets rejected for not being correct JSON (like it does for any other flat values). Config Context also correctly rejects 0 or "" values. ### Observed Behavior Change is accepted. ![Image](https://github.com/user-attachments/assets/07dfe041-dbc8-40cb-9b3a-f25fadc789d9) Relevant code: https://github.com/netbox-community/netbox/blame/v4.2.5/netbox/extras/models/configs.py#L202-L206 Happy to put up a PR for this.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:36:50 +01:00
adam closed this issue 2025-12-29 21:36:51 +01:00
adam commented 2025-12-29 21:36:51 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Mar 8, 2025):

Thanks for volunteering @fabi125 , assigned it to you.

@jnovinger commented on GitHub (Mar 8, 2025): Thanks for volunteering @fabi125 , assigned it to you.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?