starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Fix accessor syntax useage in table column configuration #10857

New Issue
Closed
opened 2025-12-29 21:36:47 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:36:47 +01:00
Owner
Copy Link

Originally created by @jnovinger on GitHub (Mar 6, 2025).

Proposed Changes

We have several at least one django_tables.Table sub-class that uses the . notation to specify related objects. This notation was deprecated in django-tables2 v2.2.0 in favor of using the __ notation.

For example, in circuits.tables.CircuitTerminationTable we define a column provider that uses accessor='circuit.provider'. This will become accessor='circuit__provider'.

--> find . -iname "*.py" | xargs rg "accessor=.*[\'\"].*\."
./circuits/tables/circuits.py
114:        accessor='circuit.provider'

Justification

This will have a couple of positive effects:

  • It's required for the django-tables2 3.0 release, so will ease our upgrade path when the time comes.
  • It will eliminate unnecessary chatter in test output.
Originally created by @jnovinger on GitHub (Mar 6, 2025). ### Proposed Changes We have ~~several~~ at least one `django_tables.Table` sub-class that uses the `.` notation to specify related objects. This notation was [deprecated in django-tables2 v2.2.0](https://github.com/jieter/django-tables2/blob/master/CHANGELOG.md#220-2019-11-18) in favor of using the `__` notation. For example, in `circuits.tables.CircuitTerminationTable` we define a column `provider` that uses `accessor='circuit.provider'`. This will become `accessor='circuit__provider'`. ``` --> find . -iname "*.py" | xargs rg "accessor=.*[\'\"].*\." ./circuits/tables/circuits.py 114: accessor='circuit.provider' ``` ### Justification This will have a couple of positive effects: - It's required for the django-tables2 3.0 release, so will ease our upgrade path when the time comes. - It will eliminate unnecessary chatter in test output.
adam added the status: duplicatetype: housekeeping labels 2025-12-29 21:36:47 +01:00
adam closed this issue 2025-12-29 21:36:47 +01:00
adam commented 2025-12-29 21:36:48 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Mar 11, 2025):

Fixed in #18858

@jnovinger commented on GitHub (Mar 11, 2025): Fixed in #18858
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: duplicate type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10857
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?