starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Dashboard broken after adding widget #10831

New Issue
Closed
opened 2025-12-29 21:36:25 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:36:25 +01:00
Owner
Copy Link

Originally created by @ed-ud on GitHub (Feb 28, 2025).

Originally assigned to: @jnovinger on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.3

Python Version

3.12

Steps to Reproduce

  1. Go to main dashboard page and click Unlock.
  2. Click Add Widget.
  3. Select object type Notifications.
  4. Click Save.

Dashboard gets the error from the screenshot below.

Expected Behavior

We shouldn't be able to select models that don't work, or cause the dashboard to break.

Observed Behavior

Image

Originally created by @ed-ud on GitHub (Feb 28, 2025). Originally assigned to: @jnovinger on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.3 ### Python Version 3.12 ### Steps to Reproduce 1. Go to main dashboard page and click Unlock. 2. Click Add Widget. 3. Select object type Notifications. 4. Click Save. Dashboard gets the error from the screenshot below. ### Expected Behavior We shouldn't be able to select models that don't work, or cause the dashboard to break. ### Observed Behavior ![Image](https://github.com/user-attachments/assets/7afbf649-4691-4e96-9357-27e3a09693b5)
adam added the type: bugstatus: acceptedseverity: medium labels 2025-12-29 21:36:25 +01:00
adam closed this issue 2025-12-29 21:36:25 +01:00
adam commented 2025-12-29 21:36:26 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Mar 3, 2025):

@ed-ud Can you please re-check and update the reproduction steps. There is no "object type" Notifications by default, there is a Widget type. I tried Widget Type: object Counts and Models: Extras > Notifications, but that worked fine on mine.

Image

@arthanson commented on GitHub (Mar 3, 2025): @ed-ud Can you please re-check and update the reproduction steps. There is no "object type" Notifications by default, there is a Widget type. I tried Widget Type: object Counts and Models: Extras > Notifications, but that worked fine on mine. ![Image](https://github.com/user-attachments/assets/886b3ca4-d68b-4842-82b2-eb9ea50cb437)
adam commented 2025-12-29 21:36:26 +01:00
Author
Owner
Copy Link

@ed-ud commented on GitHub (Mar 3, 2025):

Sorry... select Object List and then select Model: Extras > Notification

@ed-ud commented on GitHub (Mar 3, 2025): Sorry... select Object List and then select Model: Extras > Notification
adam commented 2025-12-29 21:36:27 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Mar 4, 2025):

This is hard to get to do, and there is the workaround, but once you do this the dashboard is hosed and people will need to lookup how to clear the dashboard out, should be an easy fix so marking as medium priority.

@arthanson commented on GitHub (Mar 4, 2025): This is hard to get to do, and there is the workaround, but once you do this the dashboard is hosed and people will need to lookup how to clear the dashboard out, should be an easy fix so marking as medium priority.
adam commented 2025-12-29 21:36:27 +01:00
Author
Owner
Copy Link

@ed-ud commented on GitHub (Mar 4, 2025):

Someone can try to put their Notifications on the dashboard - seems like a reasonable thing to do.
It's not really "hard to get to do"... you just add a normal widget the normal way, nothing odd about it.

@ed-ud commented on GitHub (Mar 4, 2025): Someone can try to put their Notifications on the dashboard - seems like a reasonable thing to do. It's not really "hard to get to do"... you just add a normal widget the normal way, nothing odd about it.
adam commented 2025-12-29 21:36:28 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Mar 4, 2025):

Wrote a regression-ish test for this along with an ObjectListWidget.ConfigForm.clean_model() method, which caught the same issue with the following object type choices:

  + [
  +     'Core > Object Type',
  +     'DCIM > Cable Termination',
  +     'DCIM > Console Port Template',
  +     'DCIM > Console Server Port Template',
  +     'DCIM > Device Bay Template',
  +     'DCIM > Front Port Template',
  +     'DCIM > Interface Template',
  +     'DCIM > Inventory Item Template',
  +     'DCIM > Module Bay Template',
  +     'DCIM > Power Outlet Template',
  +     'DCIM > Power Port Template',
  +     'DCIM > Rear Port Template',
  +     'Extras > Bookmark',
  +     'Extras > Branch',
  +     'Extras > Dashboard',
  +     'Extras > Notification',
  +     'Extras > Staged Change',
  +     'Extras > Subscription',
  +     'IPAM > FHRP Group Assignment',
  + ]
@jnovinger commented on GitHub (Mar 4, 2025): Wrote a regression-ish test for this along with an `ObjectListWidget.ConfigForm.clean_model()` method, which caught the same issue with the following object type choices: ``` + [ + 'Core > Object Type', + 'DCIM > Cable Termination', + 'DCIM > Console Port Template', + 'DCIM > Console Server Port Template', + 'DCIM > Device Bay Template', + 'DCIM > Front Port Template', + 'DCIM > Interface Template', + 'DCIM > Inventory Item Template', + 'DCIM > Module Bay Template', + 'DCIM > Power Outlet Template', + 'DCIM > Power Port Template', + 'DCIM > Rear Port Template', + 'Extras > Bookmark', + 'Extras > Branch', + 'Extras > Dashboard', + 'Extras > Notification', + 'Extras > Staged Change', + 'Extras > Subscription', + 'IPAM > FHRP Group Assignment', + ] ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: medium status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10831
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?