starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Make ALLOW_TOKEN_RETRIEVAL = False the default #10816

New Issue
Closed
opened 2025-12-29 21:36:15 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:36:15 +01:00
Owner
Copy Link

Originally created by @hikhvar on GitHub (Feb 27, 2025).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v4.2.3

Feature type

Change to existing functionality

Proposed functionality

Currently,
a newly setup netbox will have set ALLOW_TOKEN_RETRIEVAL = True. This is a bad and insecure default, as API tokens of users should not be visible to administrators.

Use case

Be more secure by default.

If somebody gets administrator permissions on accident (people make errors), they immediatly have access to all tokens with the current default. That should not be the case

Database changes

No response

External dependencies

No response

Originally created by @hikhvar on GitHub (Feb 27, 2025). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v4.2.3 ### Feature type Change to existing functionality ### Proposed functionality Currently, a newly setup netbox will have set ALLOW_TOKEN_RETRIEVAL = True. This is a bad and insecure default, as API tokens of users should not be visible to administrators. ### Use case Be more secure by default. If somebody gets administrator permissions on accident (people make errors), they immediatly have access to all tokens with the current default. That should not be the case ### Database changes _No response_ ### External dependencies _No response_
adam added the status: acceptedtype: featurebreaking changecomplexity: low labels 2025-12-29 21:36:15 +01:00
adam closed this issue 2025-12-29 21:36:15 +01:00
adam commented 2025-12-29 21:36:16 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Mar 6, 2025):

This needs to be picked up in a minor release as changing the default behavior is considered a breaking change.

@jeremystretch commented on GitHub (Mar 6, 2025): This needs to be picked up in a minor release as changing the default behavior is considered a breaking change.
adam commented 2025-12-29 21:36:16 +01:00
Author
Owner
Copy Link

@hikhvar commented on GitHub (Mar 7, 2025):

Can we pick it for netbox v4.3 as that is the next minor release? I would happily take the topic and implement it.

@hikhvar commented on GitHub (Mar 7, 2025): Can we pick it for netbox v4.3 as that is the next minor release? I would happily take the topic and implement it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label breaking change complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?