starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Check asserts and replace with RaiseError where appropriate #10776

New Issue
Open
opened 2025-12-29 21:35:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:35:49 +01:00
Owner
Copy Link

Originally created by @arthanson on GitHub (Feb 18, 2025).

Proposed Changes

There are several places in the code where asserts are used (cables.py, events, bulk_views). There should be a code review of the places where asserts are used in the codebase and replaced where appropriate with a raised error.

Justification

Asserts are removed when not running in debug mode. It was noticed in the cabling code that the asserts were used in places where actually errors should have been raised to catch it in production environments. So an code review should be done on all these usages and make sure an assert is appropriate or if a RaiseError should be used.

Originally created by @arthanson on GitHub (Feb 18, 2025). ### Proposed Changes There are several places in the code where asserts are used (cables.py, events, bulk_views). There should be a code review of the places where asserts are used in the codebase and replaced where appropriate with a raised error. ### Justification Asserts are removed when not running in debug mode. It was noticed in the cabling code that the asserts were used in places where actually errors should have been raised to catch it in production environments. So an code review should be done on all these usages and make sure an assert is appropriate or if a RaiseError should be used.
adam added the type: housekeepingstatus: backlog labels 2025-12-29 21:35:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label status: backlog type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10776
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?