starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Shift-click selection selects hidden interfaces #10756

New Issue
Closed
opened 2025-12-29 21:35:36 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:35:36 +01:00
Owner
Copy Link

Originally created by @tobikris on GitHub (Feb 11, 2025).

Originally assigned to: @jnovinger on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.3

Python Version

3.12

Steps to Reproduce

  1. Create Device.
  2. Create physical interface "et-0/0/0".
  3. Create virtual interface "et-0/0/0.0".
  4. Create physical interface "et-0/0/1".
  5. Enable "Hide virtual interfaces".
  6. Toggle selection check boxes of physical interfaces using Shift-click.
  7. Show virtual interfaces again.

Expected Behavior

Only the physical interfaces should be selected. This would be consistent with the usage of the "Select all" check box.

Observed Behavior

The virtual interfaces "between" the selected physical interfaces are also selected.

Originally created by @tobikris on GitHub (Feb 11, 2025). Originally assigned to: @jnovinger on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.3 ### Python Version 3.12 ### Steps to Reproduce 1. Create Device. 2. Create physical interface "et-0/0/0". 3. Create virtual interface "et-0/0/0.0". 4. Create physical interface "et-0/0/1". 5. Enable "Hide virtual interfaces". 6. Toggle selection check boxes of physical interfaces using Shift-click. 7. Show virtual interfaces again. ### Expected Behavior Only the physical interfaces should be selected. This would be consistent with the usage of the "Select all" check box. ### Observed Behavior The virtual interfaces "between" the selected physical interfaces are also selected.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:35:36 +01:00
adam closed this issue 2025-12-29 21:35:36 +01:00
adam commented 2025-12-29 21:35:37 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Feb 11, 2025):

This can probably be fixed by tweaking toggleCheckboxRange to ignore hidden checkbox fields.

@jeremystretch commented on GitHub (Feb 11, 2025): This can probably be fixed by tweaking [`toggleCheckboxRange`](https://github.com/netbox-community/netbox/blob/015ef25ca03291ab111c0e86169013f79269a57d/netbox/project-static/src/buttons/selectMultiple.ts#L36) to ignore hidden checkbox fields.
adam commented 2025-12-29 21:35:37 +01:00
Author
Owner
Copy Link

@jnovinger commented on GitHub (Feb 18, 2025):

Going to go ahead and claim this one. @jeremystretch was correct, tweaking toggleCheckboxRange does the trick, I just need to figure out the best way to detect when a checkbox is hidden.

@jnovinger commented on GitHub (Feb 18, 2025): Going to go ahead and claim this one. @jeremystretch was correct, tweaking `toggleCheckboxRange` does the trick, I just need to figure out the best way to detect when a checkbox is hidden.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?