starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Plugins not covered by get_absolute_url() #10724

New Issue
Closed
opened 2025-12-29 21:35:13 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:35:13 +01:00
Owner
Copy Link

Originally created by @alehaa on GitHub (Feb 2, 2025).

Originally assigned to: @alehaa on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.2.2

Python Version

3.11

Steps to Reproduce

  1. Create example plugin skeleton.
  2. Add a custom model. Do not define get_absolute_url() as introduced by #17693 / NetBox v4.2.
  3. Run manage.py runserver
  4. Create new model object and save it.
  5. Run get_absolute_url() method of object.

Expected Behavior

The URL is returned.

Observed Behavior

An Exception is raised:

NoReverseMatch at /plugins/hello_world/foo/

'netbox_hello_world' is not a registered namespace

Originally created by @alehaa on GitHub (Feb 2, 2025). Originally assigned to: @alehaa on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.2.2 ### Python Version 3.11 ### Steps to Reproduce 1. Create example plugin skeleton. 2. Add a custom model. Do not define `get_absolute_url()` as introduced by #17693 / NetBox v4.2. 3. Run `manage.py runserver` 4. Create new model object and save it. 5. Run `get_absolute_url()` method of object. ### Expected Behavior The URL is returned. ### Observed Behavior An Exception is raised: > NoReverseMatch at /plugins/hello_world/foo/ > > 'netbox_hello_world' is not a registered namespace
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:35:13 +01:00
adam closed this issue 2025-12-29 21:35:13 +01:00
adam commented 2025-12-29 21:35:14 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Feb 2, 2025):

PR #17693 added a generic get_absolute_url() method to NetBoxModel. However, plugins are in a different URL namespace than regular NetBox models. I think this is not covered yet.

To solve this problem, I suggest using get_viewname() utility function in get_absolute_url() instead of duplicating pathname creation. Maybe a test case can be added as well.

@alehaa commented on GitHub (Feb 2, 2025): PR #17693 added a generic `get_absolute_url()` method to `NetBoxModel`. However, plugins are in a different URL namespace than regular NetBox models. I think this is not covered yet. To solve this problem, I suggest using [`get_viewname()` utility function](https://github.com/netbox-community/netbox/blob/main/netbox/utilities/views.py#L246) in `get_absolute_url()` instead of duplicating pathname creation. Maybe a test case can be added as well.
adam commented 2025-12-29 21:35:14 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Feb 5, 2025):

This could be either a feature request or bug, leaving it as a bug for now.

@arthanson commented on GitHub (Feb 5, 2025): This could be either a feature request or bug, leaving it as a bug for now.
adam commented 2025-12-29 21:35:15 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Feb 8, 2025):

@arthanson I volunteer to work on this issue.

@alehaa commented on GitHub (Feb 8, 2025): @arthanson I volunteer to work on this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10724
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?