starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Support auth_required in PluginMenuItem #10716

New Issue
Closed
opened 2025-12-29 21:35:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:35:08 +01:00
Owner
Copy Link

Originally created by @bctiemann on GitHub (Jan 29, 2025).

Originally assigned to: @bctiemann on GitHub.

NetBox version

v4.2.2

Feature type

New functionality

Proposed functionality

At present the PluginMenuItem class is missing the auth_required attribute which is present on all regular MenuItems, and which is necessary for controlling whether the plugin's menu items appear in the nav menu. This attribute needs to be defined with a default of False.

Use case

This is necessary because of this code:

5cd7c6d167/netbox/utilities/templatetags/navigation.py (L24-L31)

Which is what determines whether a menu item is shown in the nav menu. Because auth_required is not present on PluginMenuItem, the check on L29 evaluates to False and the menu item is shown regardless of authentication state.

Database changes

N/A

External dependencies

N/A

Originally created by @bctiemann on GitHub (Jan 29, 2025). Originally assigned to: @bctiemann on GitHub. ### NetBox version v4.2.2 ### Feature type New functionality ### Proposed functionality At present the `PluginMenuItem` class is missing the `auth_required` attribute which is present on all regular `MenuItem`s, and which is necessary for controlling whether the plugin's menu items appear in the nav menu. This attribute needs to be defined with a default of `False`. ### Use case This is necessary because of this code: https://github.com/netbox-community/netbox/blob/5cd7c6d167ea3b0a23651823adbcd44c103b63c4/netbox/utilities/templatetags/navigation.py#L24-L31 Which is what determines whether a menu item is shown in the nav menu. Because `auth_required` is not present on `PluginMenuItem`, the check on L29 evaluates to `False` and the menu item is shown regardless of authentication state. ### Database changes N/A ### External dependencies N/A
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:35:08 +01:00
adam closed this issue 2025-12-29 21:35:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?