starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

prepare_cloned_fields() should check for cloning support on model #10701

New Issue
Closed
opened 2025-12-29 21:34:57 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:34:57 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Jan 27, 2025).

Originally assigned to: @arthanson on GitHub.

Deployment Type

NetBox Cloud

NetBox Version

v4.2.2

Python Version

3.10

Steps to Reproduce

  1. Define a clone() method on a plugin model, returning None.
  2. Install the plugin.
  3. Attempt to view an instance of that model.

Expected Behavior

The object should render successfully.

Observed Behavior

An unhandled AttributeError exception is raised:

'NoneType' object has no attribute 'items'

This is because NetBox expects the clone() method, if defined on a model, to return a set of attributes suitable for pre-populating the creation form for the model. However, a plugin author might want to introduce a clone() method for unrelated reasons.

NetBox should inspect the model and attempt to call clone() only for models which inherit from CloningMixin.

Originally created by @jeremystretch on GitHub (Jan 27, 2025). Originally assigned to: @arthanson on GitHub. ### Deployment Type NetBox Cloud ### NetBox Version v4.2.2 ### Python Version 3.10 ### Steps to Reproduce 1. Define a `clone()` method on a plugin model, returning None. 2. Install the plugin. 3. Attempt to view an instance of that model. ### Expected Behavior The object should render successfully. ### Observed Behavior An unhandled `AttributeError` exception is raised: > 'NoneType' object has no attribute 'items' This is because NetBox expects the `clone()` method, if defined on a model, to return a set of attributes suitable for pre-populating the creation form for the model. However, a plugin author might want to introduce a `clone()` method for unrelated reasons. NetBox should inspect the model and attempt to call `clone()` only for models which inherit from [`CloningMixin`](https://github.com/netbox-community/netbox/blob/57fa1dd18dbaa5c927ceae37b5879044b9f154e1/netbox/netbox/models/features.py#L115).
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:34:57 +01:00
adam closed this issue 2025-12-29 21:34:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10701
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?