starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Fix wrong <code>'s #10634

New Issue
Closed
opened 2025-12-29 21:33:57 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:33:57 +01:00
Owner
Copy Link

Originally created by @mathieumd on GitHub (Jan 9, 2025).

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v4.2.1

Python Version

3.10

Steps to Reproduce

French translation looks like to be machine translated. While it's great for most strings, some are misleading, like <code>. For example <code>192.0.2.[1,5,100-254]/24</code> were translated <code>192,0,2. [1 500 -254] /24</code>!

I saw you use Transifex after having manually fixed django.po. I hope you won't ask me to start from scratch there! ;-)

Expected Behavior

N/A

Observed Behavior

N/A

Originally created by @mathieumd on GitHub (Jan 9, 2025). ### Deployment Type Self-hosted ### Triage priority I volunteer to perform this work (if approved) ### NetBox Version v4.2.1 ### Python Version 3.10 ### Steps to Reproduce French translation looks like to be machine translated. While it's great for most strings, some are misleading, like `<code>`. For example `<code>192.0.2.[1,5,100-254]/24</code>` were translated `<code>192,0,2. [1 500 -254] /24</code>`! I saw you use Transifex after having manually fixed `django.po`. I hope you won't ask me to start from scratch there! ;-) ### Expected Behavior N/A ### Observed Behavior N/A
adam added the type: bug label 2025-12-29 21:33:57 +01:00
adam closed this issue 2025-12-29 21:33:58 +01:00
adam commented 2025-12-29 21:33:58 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 9, 2025):

I saw you use Transifex after having manually fixed django.po. I hope you won't ask me to start from scratch there! ;-)

Yes, all translations are done exclusively through Transifex, which is clearly stated when opening a new issue:

screenshot

We also ask contributors to wait for an issue to be approved before beginning work, for precisely this reason.

You are welcome to resubmit your proposed changes via Transifex, but we cannot accept PRs for translated strings.

@jeremystretch commented on GitHub (Jan 9, 2025): > I saw you use Transifex after having manually fixed django.po. I hope you won't ask me to start from scratch there! ;-) Yes, all translations are done exclusively through [Transifex](https://explore.transifex.com/netbox-community/netbox/), which is clearly stated when opening a [new issue](https://github.com/netbox-community/netbox/issues/new/choose): ![screenshot](https://github.com/user-attachments/assets/ec1a6a93-a205-4c80-903d-f02e3752c502) We also ask contributors to wait for an issue to be approved before beginning work, for precisely this reason. You are welcome to resubmit your proposed changes via Transifex, but we cannot accept PRs for translated strings.
adam commented 2025-12-29 21:33:58 +01:00
Author
Owner
Copy Link

@mathieumd commented on GitHub (Jan 10, 2025):

I think it should be also clearly stated in the first lines of each po files! Because I first edited the file, then created the PR, which requested an issue number. So I went to create an issue. And only then I noticed that you use Transifex. I still made the issue+PR in the hope my work would not be lost.

So it looks like I lost my time because it was not clearly stated from the(my) beginning. :-(

I made a request to join French group on Transifex.

@mathieumd commented on GitHub (Jan 10, 2025): I think it should be also clearly stated in the first lines of each po files! Because I first edited the file, then created the PR, which requested an issue number. So I went to create an issue. And only then I noticed that you use Transifex. I still made the issue+PR in the hope my work would not be lost. So it looks like I lost my time because it was *not* clearly stated from the(my) beginning. :-( I made a request to join French group on Transifex.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10634
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?