starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Replace DurationChoices by JobIntervalChoices #10599

New Issue
Closed
opened 2025-12-29 21:33:32 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:33:32 +01:00
Owner
Copy Link

Originally created by @alehaa on GitHub (Dec 31, 2024).

Originally assigned to: @alehaa on GitHub.

NetBox version

v4.2-beta1

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

During the implementation of #17716, I added the JobIntervalChoices to simplify job scheduling. At the time of writing this PR, I wasn't aware that there was already a DurationChoices in the extras module used by the script form.

I suggest replacing it with the new JobIntervalChoices and also integrating its missing choices for "12 hours" and "30 days".

Use case

Code deduplication and increasing maintainability.

Database changes

None.

External dependencies

DurationChoices has never been part of a public API, so I think there are no side effects.

Originally created by @alehaa on GitHub (Dec 31, 2024). Originally assigned to: @alehaa on GitHub. ### NetBox version v4.2-beta1 ### Feature type Change to existing functionality ### Triage priority I volunteer to perform this work (if approved) ### Proposed functionality During the implementation of #17716, I added the `JobIntervalChoices` to simplify job scheduling. At the time of writing this PR, I wasn't aware that there was already a `DurationChoices` in the extras module used by the script form. I suggest replacing it with the new `JobIntervalChoices` and also integrating its missing choices for "12 hours" and "30 days". ### Use case Code deduplication and increasing maintainability. ### Database changes None. ### External dependencies `DurationChoices` has never been part of a public API, so I think there are no side effects.
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:33:32 +01:00
adam closed this issue 2025-12-29 21:33:32 +01:00
adam commented 2025-12-29 21:33:33 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Feb 13, 2025):

@alehaa do you want me to assign this to you?

@arthanson commented on GitHub (Feb 13, 2025): @alehaa do you want me to assign this to you?
adam commented 2025-12-29 21:33:33 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Feb 13, 2025):

@arthanson you can assign this to me, thanks.

@alehaa commented on GitHub (Feb 13, 2025): @arthanson you can assign this to me, thanks.
adam commented 2025-12-29 21:33:33 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Feb 13, 2025):

@alehaa assigned.

@arthanson commented on GitHub (Feb 13, 2025): @alehaa assigned.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?