starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Allow optional Q-in-Q role on VLAN Groups #10591

New Issue
Open
opened 2025-12-29 21:33:29 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:33:29 +01:00
Owner
Copy Link

Originally created by @sleepinggenius2 on GitHub (Dec 30, 2024).

NetBox version

v4.2-beta1

Feature type

Data model extension

Triage priority

N/A

Proposed functionality

Copy the qinq_role field from the Vlan model to the VlanGroup model. Add validation to only allow VLANs of the same role in the group.

If the Q-in-Q role is empty, I think it makes sense to allow VLANs with any Q-in-Q role, but I could also see an argument to only allow VLANs without a Q-in-Q role set and to add an additional Q-in-Q role of "Any" or "Mixed" to the VLAN Group model to explicitly allow VLANs with non-empty Q-in-Q roles as well.

Use case

If using a VLAN Group to document the VLANs available on an ENNI, they must all be SVLANs, likewise on a UNI they must all be CVLANs, so it would be nice to have the system be able to enforce that out of the box.

Database changes

Copy the qinq_role field from the Vlan model to the VlanGroup model.

External dependencies

None

Originally created by @sleepinggenius2 on GitHub (Dec 30, 2024). ### NetBox version v4.2-beta1 ### Feature type Data model extension ### Triage priority N/A ### Proposed functionality Copy the `qinq_role` field from the `Vlan` model to the `VlanGroup` model. Add validation to only allow VLANs of the same role in the group. If the Q-in-Q role is empty, I think it makes sense to allow VLANs with any Q-in-Q role, but I could also see an argument to only allow VLANs without a Q-in-Q role set and to add an additional Q-in-Q role of "Any" or "Mixed" to the VLAN Group model to explicitly allow VLANs with non-empty Q-in-Q roles as well. ### Use case If using a VLAN Group to document the VLANs available on an ENNI, they must all be SVLANs, likewise on a UNI they must all be CVLANs, so it would be nice to have the system be able to enforce that out of the box. ### Database changes Copy the `qinq_role` field from the `Vlan` model to the `VlanGroup` model. ### External dependencies None
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: medium needs milestone netbox status: backlog type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10591
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?