starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Enable the dynamic registration of context managers for request processing (i.e. event_tracking()) #10567

New Issue
Closed
opened 2025-12-29 21:33:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:33:13 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Dec 11, 2024).

Originally assigned to: @jeremystretch on GitHub.

NetBox version

v4.1.8

Feature type

Change to existing functionality

Triage priority

N/A

Proposed functionality

NetBox currently employs its event_tracking() context manager to process events triggered by a request, e.g. for change change logging. This function is invoked explicitly by the CoreMiddleware class.

Instead of calling this function directly, we can register it within NetBox's application registry, and consult the registry for all registered request processors whenever necessary, including within the middleware as well as for other purposes (such as running a background job).

Use case

This approach will enable to us to dynamically register additional request processors, such as those which may be introduced by plugins, without the need for explicit configuration. #18136 raises one such use case.

Database changes

N/A

External dependencies

N/A

Originally created by @jeremystretch on GitHub (Dec 11, 2024). Originally assigned to: @jeremystretch on GitHub. ### NetBox version v4.1.8 ### Feature type Change to existing functionality ### Triage priority N/A ### Proposed functionality NetBox currently employs its [`event_tracking()`](https://github.com/netbox-community/netbox/blob/a15ff294dd95815027575ae65e0483c8ab29ffe6/netbox/netbox/context_managers.py#L8) context manager to process events triggered by a request, e.g. for change change logging. This function is invoked explicitly by the `CoreMiddleware` class. Instead of calling this function directly, we can register it within NetBox's [application registry](https://netboxlabs.com/docs/netbox/en/stable/development/application-registry/), and consult the registry for all registered request processors whenever necessary, including within the middleware as well as for other purposes (such as running a background job). ### Use case This approach will enable to us to dynamically register additional request processors, such as those which may be introduced by plugins, without the need for explicit configuration. #18136 raises one such use case. ### Database changes N/A ### External dependencies N/A
adam added the status: acceptedtype: featurecomplexity: medium labels 2025-12-29 21:33:13 +01:00
adam closed this issue 2025-12-29 21:33:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: medium status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?