starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Degradation of GraphQL and Rest API query performance #10522

New Issue
Closed
opened 2025-12-29 21:32:35 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:32:35 +01:00
Owner
Copy Link

Originally created by @TheLastochka on GitHub (Nov 29, 2024).

Deployment Type

Self-hosted

Triage priority

I'm a NetBox Labs customer

NetBox Version

v4.1.6

Python Version

3.11

Steps to Reproduce

  1. Netbox version >= 4.0.0
  2. The database contains about 27k ip addresses
  3. Send the following Graphql query:
query getIpAddresses {
  resp:ip_address_list {
    id
    address
    status
    description
    dns_name
    tenant {
      id
      name
    }
    assigned_object {
      __typename
      ... on InterfaceType {
        id
        name
      }
      ... on VMInterfaceType {
        id
        name
      }
    }
    custom_fields
  }
}

After switching to the Strawberry library (netbox v4.0.0), there has been a significant degradation in the performance of API requests, including Graphql.
When executing a request to get custom fields or an assigned objects, Graphql performs additional queries to the database in large numbers.

Expected Behavior

It works in Netbox v3.7.8:

  1. This query produced 5k database queries (execution time: 14 seconds).
  2. If you remove assigned_object's and custom_fields from this Graphql query, the execution time does not change (slightly).

Observed Behavior

Netbox v4.0.0 (Strawberry) and after:

  1. The same query produces 87k database queries (execution time: 7.6 minutes).
  2. If you remove assigned_object's and custom_fields from this Graphql query, the execution time drops to the expected values (execution time is 8 seconds).

Previously, there was a similar problem on the netbox v3.4 version https://github.com/netbox-community/netbox/issues/11291
However, it was fixed in version v3.5 by writing optimizers.

After switching to Strawberry, the optimizers remained in the old code. And the problem is back.

Originally posted by @TheLastochka in https://github.com/netbox-community/netbox/discussions/18107

Originally created by @TheLastochka on GitHub (Nov 29, 2024). ### Deployment Type Self-hosted ### Triage priority I'm a NetBox Labs customer ### NetBox Version v4.1.6 ### Python Version 3.11 ### Steps to Reproduce 1. Netbox version >= 4.0.0 2. The database contains about 27k ip addresses 3. Send the following Graphql query: ``` query getIpAddresses { resp:ip_address_list { id address status description dns_name tenant { id name } assigned_object { __typename ... on InterfaceType { id name } ... on VMInterfaceType { id name } } custom_fields } } ``` After switching to the Strawberry library (netbox v4.0.0), there has been a significant degradation in the performance of API requests, including Graphql. When executing a request to get custom fields or an assigned objects, Graphql performs additional queries to the database in large numbers. ### Expected Behavior It works in Netbox v3.7.8: 1. This query produced 5k database queries (execution time: 14 seconds). 2. If you remove assigned_object's and custom_fields from this Graphql query, the execution time does not change (slightly). ### Observed Behavior Netbox v4.0.0 (Strawberry) and after: 1. The same query produces 87k database queries (execution time: 7.6 minutes). 2. If you remove assigned_object's and custom_fields from this Graphql query, the execution time drops to the expected values (execution time is 8 seconds). Previously, there was a similar problem on the netbox v3.4 version https://github.com/netbox-community/netbox/issues/11291 However, it was fixed in version v3.5 by writing optimizers. After switching to Strawberry, the optimizers remained in the old code. And the problem is back. _Originally posted by @TheLastochka in https://github.com/netbox-community/netbox/discussions/18107_
adam closed this issue 2025-12-29 21:32:35 +01:00
adam commented 2025-12-29 21:32:36 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Dec 5, 2024):

Hacked a quick script to generate ip addresses and was able to replicate, probably needs select_related in the GraphQL queries. There is a query optimizer built into Strawberry, not sure why it isn't optimizing these.

@arthanson commented on GitHub (Dec 5, 2024): Hacked a quick script to generate ip addresses and was able to replicate, probably needs select_related in the GraphQL queries. There is a query optimizer built into Strawberry, not sure why it isn't optimizing these.
adam commented 2025-12-29 21:32:36 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 24, 2025):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Apr 24, 2025): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/main/CONTRIBUTING.md).
adam commented 2025-12-29 21:32:36 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 25, 2025):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (May 25, 2025): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pending closure severity: low status: needs owner topic: GraphQL type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?