starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Remove or hide password in Data Source UI #10474

New Issue
Closed
opened 2025-12-29 21:31:58 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:31:58 +01:00
Owner
Copy Link

Originally created by @mskalecki on GitHub (Nov 13, 2024).

Originally assigned to: @mskalecki on GitHub.

NetBox version

v4.1.6

Feature type

Change to existing functionality

Triage priority

I volunteer to perform this work (if approved)

Proposed functionality

Remove or hide the plain text password that is currently displayed in the Backend section of the Data Source view.

Use case

I'm using fine-grained personal access tokens to connect to private GitHub repositories as Data Sources. While these access tokens have very minimal permissions, I don't think they should be displayed in plain text any time I navigate to the Data Source in the UI.

At a minimum, the password / PAT should be hidden (requiring a click to expose the plain text), but I can't see any good reason to show them at all and would just remove it from the view entirely.

Database changes

None

External dependencies

None

Originally created by @mskalecki on GitHub (Nov 13, 2024). Originally assigned to: @mskalecki on GitHub. ### NetBox version v4.1.6 ### Feature type Change to existing functionality ### Triage priority I volunteer to perform this work (if approved) ### Proposed functionality Remove or hide the plain text password that is currently displayed in the `Backend` section of the `Data Source` view. ### Use case I'm using fine-grained personal access tokens to connect to private GitHub repositories as Data Sources. While these access tokens have very minimal permissions, I don't think they should be displayed in plain text any time I navigate to the Data Source in the UI. At a minimum, the password / PAT should be hidden (requiring a click to expose the plain text), but I can't see any good reason to show them at all and would just remove it from the view entirely. ### Database changes None ### External dependencies None
adam added the status: acceptedtype: featurecomplexity: low labels 2025-12-29 21:31:58 +01:00
adam closed this issue 2025-12-29 21:31:58 +01:00
adam commented 2025-12-29 21:31:58 +01:00
Author
Owner
Copy Link

@mskalecki commented on GitHub (Nov 13, 2024):

I took a look at the relevant html template, and I see that the sensitive_parameters (including password) are hidden from users who don't have permissions to change the fields, but really this should be hidden from everyone, especially in the non-edit view.

@mskalecki commented on GitHub (Nov 13, 2024): I took a look at the relevant html template, and I see that the `sensitive_parameters` (including `password`) are hidden from users who don't have permissions to change the fields, but really this should be hidden from everyone, especially in the non-edit view.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low status: accepted type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10474
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?