starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Enable additional Ruff validation rules #10452

New Issue
Closed
opened 2025-12-29 21:31:37 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:31:37 +01:00
Owner
Copy Link

Originally created by @jeremystretch on GitHub (Nov 7, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

We currently employ Ruff for linting, using the default rule set (excluding a few rules). We can increase linter coverage by enabling preview mode and including additional rules.

Specifically, I propose including the E100, E200, and E300 series of rules (most of which are currently in preview mode), but upon further exploration we might find it prudent to include additional rules.

For reference, Ruff currently reports a total of 29 trivial errors attributable to these rules.

Justification

This will increase linter coverage with little overhead cost.

Originally created by @jeremystretch on GitHub (Nov 7, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes We currently employ [Ruff](https://docs.astral.sh/ruff/) for linting, using the default rule set (excluding a few rules). We can increase linter coverage by enabling [preview mode](https://docs.astral.sh/ruff/preview/#deprecated-rules) and including additional rules. Specifically, I propose including the [E100, E200, and E300](https://docs.astral.sh/ruff/rules/#error-e) series of rules (most of which are currently in preview mode), but upon further exploration we might find it prudent to include additional rules. For reference, Ruff currently reports a total of 29 trivial errors attributable to these rules. ### Justification This will increase linter coverage with little overhead cost.
adam added the status: acceptedtype: housekeepingnetbox labels 2025-12-29 21:31:37 +01:00
adam closed this issue 2025-12-29 21:31:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10452
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?