starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Cable bulk import when importing circuit terminations #10451

New Issue
Open
opened 2025-12-29 21:31:37 +01:00 by adam · 16 comments
adam commented 2025-12-29 21:31:37 +01:00
Owner
Copy Link

Originally created by @Sergii-Lucky on GitHub (Nov 7, 2024).

Originally assigned to: @jsenecal on GitHub.

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v.4.1.6

Python Version

3.12

Steps to Reproduce

When trying to use the bulk cable import feature to import cables with circuit terminations, I'm getting the error "Record 1 side_a_device: Object not found:397718".

To reproduce:
I have an existing device NTT-ODF1 with a port X01.
I have an existing circuit, 397718 and I'm trying to connect to Termination A

Import data:
side_a_device,side_a_type,side_a_name,side_b_device,side_b_type,side_b_name
397718,circuits.circuittermination,A,NTT-ODF1,dcim.rearport,X01

Expected Behavior

Should be able to import cables connected to circuit terminations.

Observed Behavior

Screenshot 2024-11-07 at 16 50 17 Screenshot 2024-11-07 at 16 46 55 Screenshot 2024-11-07 at 16 46 22
Originally created by @Sergii-Lucky on GitHub (Nov 7, 2024). Originally assigned to: @jsenecal on GitHub. ### Deployment Type Self-hosted ### Triage priority I volunteer to perform this work (if approved) ### NetBox Version v.4.1.6 ### Python Version 3.12 ### Steps to Reproduce When trying to use the bulk cable import feature to import cables with circuit terminations, I'm getting the error "Record 1 side_a_device: Object not found:397718". To reproduce: I have an existing device NTT-ODF1 with a port X01. I have an existing circuit, 397718 and I'm trying to connect to Termination A Import data: side_a_device,side_a_type,side_a_name,side_b_device,side_b_type,side_b_name 397718,circuits.circuittermination,A,NTT-ODF1,dcim.rearport,X01 ### Expected Behavior Should be able to import cables connected to circuit terminations. ### Observed Behavior <img width="1512" alt="Screenshot 2024-11-07 at 16 50 17" src="https://github.com/user-attachments/assets/8759bfed-e5e7-473d-b749-3ea9244528bf"> <img width="1201" alt="Screenshot 2024-11-07 at 16 46 55" src="https://github.com/user-attachments/assets/e94d6c07-10f7-477c-ac2f-625c44fd1591"> <img width="382" alt="Screenshot 2024-11-07 at 16 46 22" src="https://github.com/user-attachments/assets/fa382144-dba6-43a0-b955-a813fe686590">
adam added the type: bugstatus: acceptednetboxseverity: low labels 2025-12-29 21:31:37 +01:00
adam commented 2025-12-29 21:31:38 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Nov 11, 2024):

I noticed the same today. I have found the culprit and would be willing to submit a fix for it @bctiemann @Sergii-Lucky,

_clean_side is missing the use-case of circuitterminations and this could probably be added easily.

If @Sergii-Lucky would like me to take this issue, just let me know and I'll start working on a fix.

@jsenecal commented on GitHub (Nov 11, 2024): I noticed the same today. I have found the culprit and would be willing to submit a fix for it @bctiemann @Sergii-Lucky, [_clean_side](https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/forms/bulk_import.py#L1239) is missing the use-case of circuitterminations and this could probably be added easily. If @Sergii-Lucky would like me to take this issue, just let me know and I'll start working on a fix.
adam commented 2025-12-29 21:31:38 +01:00
Author
Owner
Copy Link

@Sergii-Lucky commented on GitHub (Nov 11, 2024):

@jsenecal
Yes, of course.
Let me know if you need additional information or any help from my side.

@Sergii-Lucky commented on GitHub (Nov 11, 2024): @jsenecal Yes, of course. Let me know if you need additional information or any help from my side.
adam commented 2025-12-29 21:31:38 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Nov 12, 2024):

Thanks @jsenecal, I've assigned this to you.

@jeremystretch commented on GitHub (Nov 12, 2024): Thanks @jsenecal, I've assigned this to you.
adam commented 2025-12-29 21:31:38 +01:00
Author
Owner
Copy Link

@sleepinggenius2 commented on GitHub (Nov 12, 2024):

While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed.

@sleepinggenius2 commented on GitHub (Nov 12, 2024): While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed.
adam commented 2025-12-29 21:31:38 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Nov 13, 2024):

While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed.

This is another issue with a similar fix. Can you link the issue so I can submit a different PR @sleepinggenius2 ?

@jsenecal commented on GitHub (Nov 13, 2024): > While this is being fixed for circuit terminations, I believe there is currently a similar issue for Power Feed type terminations, which should probably also be addressed. This is another issue with a similar fix. Can you link the issue so I can submit a different PR @sleepinggenius2 ?
adam commented 2025-12-29 21:31:39 +01:00
Author
Owner
Copy Link

@sleepinggenius2 commented on GitHub (Nov 13, 2024):

I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here?

@sleepinggenius2 commented on GitHub (Nov 13, 2024): I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here?
adam commented 2025-12-29 21:31:39 +01:00
Author
Owner
Copy Link

@Sergii-Lucky commented on GitHub (Nov 13, 2024):

I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here?

Please open a new one.
I am not sure if it's necessary to link it here.

@Sergii-Lucky commented on GitHub (Nov 13, 2024): > I'm not aware of a Github issue opened for that at this time. Can it be included as part of this one or should I open a new one and link it here? Please open a new one. I am not sure if it's necessary to link it here.
adam commented 2025-12-29 21:31:39 +01:00
Author
Owner
Copy Link

@sleepinggenius2 commented on GitHub (Nov 13, 2024):

I have opened #18008 for the power feed use case.

@sleepinggenius2 commented on GitHub (Nov 13, 2024): I have opened #18008 for the power feed use case.
adam commented 2025-12-29 21:31:39 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Nov 22, 2024):

@jeremystretch, not sure if you noticed but I submitted a PR for this bug

@jsenecal commented on GitHub (Nov 22, 2024): @jeremystretch, not sure if you noticed but I submitted a PR for this bug
adam commented 2025-12-29 21:31:39 +01:00
Author
Owner
Copy Link

@pobk commented on GitHub (Jun 20, 2025):

Waht would be the best way to progress this?

@pobk commented on GitHub (Jun 20, 2025): Waht would be the best way to progress this?
adam commented 2025-12-29 21:31:40 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Jun 23, 2025):

This was discussed in my original attempt to fix this @pobk, please go ahead and read through https://github.com/netbox-community/netbox/pull/17995

@jsenecal commented on GitHub (Jun 23, 2025): This was discussed in my original attempt to fix this @pobk, please go ahead and read through https://github.com/netbox-community/netbox/pull/17995
adam commented 2025-12-29 21:31:40 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Sep 22, 2025):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Sep 22, 2025): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/main/CONTRIBUTING.md).
adam commented 2025-12-29 21:31:40 +01:00
Author
Owner
Copy Link

@jjoves73 commented on GitHub (Oct 7, 2025):

There is 2 ways this can be achieved I think
via circuit termination bulk upload

  • add the ability to point to an interface and a circuit and not just circuit provider, region, sitegroup, site and location
    via connections Bulk cable upload
  • i think there is a bug here - we have termination type - circuits.circuittermination - but no specific object that relates to the circuit.
@jjoves73 commented on GitHub (Oct 7, 2025): There is 2 ways this can be achieved I think via circuit termination bulk upload - add the ability to point to an interface and a circuit and not just circuit provider, region, sitegroup, site and location via connections Bulk cable upload - i think there is a bug here - we have termination type - circuits.circuittermination - but no specific object that relates to the circuit.
adam commented 2025-12-29 21:31:41 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 7, 2025):

@jjoves73 are you volunteering to own this?

@jeremystretch commented on GitHub (Oct 7, 2025): @jjoves73 are you volunteering to own this?
adam commented 2025-12-29 21:31:41 +01:00
Author
Owner
Copy Link

@jjoves73 commented on GitHub (Oct 7, 2025):

I’m sorry but I am not a coder myself. Just a netbox user who just wanting this feature and issue resolved as well. I am more like a user tester. I wish I knew how to code…

@jjoves73 commented on GitHub (Oct 7, 2025): I’m sorry but I am not a coder myself. Just a netbox user who just wanting this feature and issue resolved as well. I am more like a user tester. I wish I knew how to code…
adam commented 2025-12-29 21:31:41 +01:00
Author
Owner
Copy Link

@jsenecal commented on GitHub (Nov 20, 2025):

So, I gave it another go in #20843, this would solve #18008 as well

@jsenecal commented on GitHub (Nov 20, 2025): So, I gave it another go in #20843, this would solve #18008 as well
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?