starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Incorrect Tooltips on Connection buttons #1044

New Issue
Closed
opened 2025-12-29 16:28:14 +01:00 by adam · 6 comments
adam commented 2025-12-29 16:28:14 +01:00
Owner
Copy Link

Originally created by @traveler3468 on GitHub (Jun 16, 2017).

Issue type: Bug Report

**Python version: 2
**NetBox version: 2.0.4

When making connections I realized that the tooltip's on the connection buttons seem wrong to me. When the interface is connected and it displays the plug icon the tooltip says "Mark Connected" when the the button icon is displaying the circle with a line through it, the tool tip displays "Mark Disconnected"
button bug
button bug2

Originally created by @traveler3468 on GitHub (Jun 16, 2017). ### Issue type: Bug Report **Python version: 2 **NetBox version: 2.0.4 When making connections I realized that the tooltip's on the connection buttons seem wrong to me. When the interface is connected and it displays the plug icon the tooltip says "Mark Connected" when the the button icon is displaying the circle with a line through it, the tool tip displays "Mark Disconnected" ![button bug](https://user-images.githubusercontent.com/29483942/27228695-adc6cfe6-5276-11e7-87c2-ceee54b86a3d.png) ![button bug2](https://user-images.githubusercontent.com/29483942/27228696-adca6ea8-5276-11e7-8635-060049abc8fa.png)
adam added the type: bug label 2025-12-29 16:28:14 +01:00
adam closed this issue 2025-12-29 16:28:14 +01:00
adam commented 2025-12-29 16:28:14 +01:00
Author
Owner
Copy Link

@traveler3468 commented on GitHub (Jun 16, 2017):

Update: it also sometimes displays "Mark Planned"

@traveler3468 commented on GitHub (Jun 16, 2017): Update: it also sometimes displays "Mark Planned"
adam commented 2025-12-29 16:28:14 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 16, 2017):

It should read "mark connected" or "mark planned," to indicate whether the connection has been physically installed. Maybe "mark installed"/"mark planned" is more clear.

@jeremystretch commented on GitHub (Jun 16, 2017): It should read "mark connected" or "mark planned," to indicate whether the connection has been physically installed. Maybe "mark installed"/"mark planned" is more clear.
adam commented 2025-12-29 16:28:15 +01:00
Author
Owner
Copy Link

@traveler3468 commented on GitHub (Jun 16, 2017):

I think the wording is ok but maybe they should be flipped so that when you hover over the circle with the line through it, it displays "mark connected" and vice versa. That to me says that when I hover over it it should tell me what its going to do when I click the button.

@traveler3468 commented on GitHub (Jun 16, 2017): I think the wording is ok but maybe they should be flipped so that when you hover over the circle with the line through it, it displays "mark connected" and vice versa. That to me says that when I hover over it it should tell me what its going to do when I click the button.
adam commented 2025-12-29 16:28:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 16, 2017):

Planned connections are highlighted in blue. Clicking the circle marks an installed connection as planned. Clicking the plug marks a planned connection as installed.

@jeremystretch commented on GitHub (Jun 16, 2017): Planned connections are highlighted in blue. Clicking the circle marks an installed connection as planned. Clicking the plug marks a planned connection as installed.
adam commented 2025-12-29 16:28:15 +01:00
Author
Owner
Copy Link

@traveler3468 commented on GitHub (Jun 16, 2017):

Ahhh, I see. That does make more sense. I didnt even pay attention to the fact that the line turns green when the plug icon is clicked. Green means UP/connected. Am I understanding that correctly?

@traveler3468 commented on GitHub (Jun 16, 2017): Ahhh, I see. That does make more sense. I didnt even pay attention to the fact that the line turns green when the plug icon is clicked. Green means UP/connected. Am I understanding that correctly?
adam commented 2025-12-29 16:28:15 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jun 16, 2017):

Oh, I see what's happening. The Javascript is assigning the title to the wrong element, so you can end up with an icon that says "mark connected" inside a button that says "mark planned" after toggling a connection. Need to fix that.

Green means UP/connected. Am I understanding that correctly?

Yep, but only after toggling a connection. If you reload the page, connections are no longer highlighted.

@jeremystretch commented on GitHub (Jun 16, 2017): Oh, I see what's happening. The Javascript is assigning the title to the wrong element, so you can end up with an icon that says "mark connected" inside a button that says "mark planned" after toggling a connection. Need to fix that. > Green means UP/connected. Am I understanding that correctly? Yep, but only after toggling a connection. If you reload the page, connections are no longer highlighted.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#1044
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?