starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[Blocks all PRs] Failing test_background_task_stop test #10416

New Issue
Closed
opened 2025-12-29 21:31:10 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:31:10 +01:00
Owner
Copy Link

Originally created by @prryplatypus on GitHub (Oct 29, 2024).

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.5

Python Version

3.10

Steps to Reproduce

  1. Run the tests

Expected Behavior

Tests pass

Observed Behavior

Tests fail

Originally created by @prryplatypus on GitHub (Oct 29, 2024). ### Deployment Type Self-hosted ### Triage priority N/A ### NetBox Version v4.1.5 ### Python Version 3.10 ### Steps to Reproduce 1. Run the tests ### Expected Behavior Tests pass ### Observed Behavior Tests fail
adam added the type: bugnetbox labels 2025-12-29 21:31:10 +01:00
adam closed this issue 2025-12-29 21:31:10 +01:00
adam commented 2025-12-29 21:31:10 +01:00
Author
Owner
Copy Link

@prryplatypus commented on GitHub (Oct 29, 2024):

This is because of this issue: https://github.com/rq/django-rq/issues/682

TL;DR:

  • Netbox is pinned to a django-rq version that doesn't pin rq to <2.0.0.
  • rq has just released 2.0.0 about 9h ago which breaks the test_background_task_stop test in Netbox (since django-rq is happy accepting the new version).

As a temporary fix Netbox can simply pin rq<2.0.0. The definitive fix could be either:

  • In django-rq's hands to release a new patched version and have Netbox upgrade to it (issue linked above)
  • In rq if the logic being used in the test shouldn't have changed behaviour (haven't had time to check if that is the case)
@prryplatypus commented on GitHub (Oct 29, 2024): This is because of this issue: https://github.com/rq/django-rq/issues/682 TL;DR: - Netbox is pinned to a `django-rq` version that doesn't pin `rq` to `<2.0.0`. - `rq` has just released `2.0.0` about 9h ago which breaks the `test_background_task_stop` test in Netbox (since `django-rq` is happy accepting the new version). As a temporary fix Netbox can simply pin `rq<2.0.0`. The definitive fix could be either: - In `django-rq`'s hands to release a new patched version and have Netbox upgrade to it (issue linked above) - In `rq` if the logic being used in the test shouldn't have changed behaviour (haven't had time to check if that is the case)
adam commented 2025-12-29 21:31:11 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 29, 2024):

This has already been addressed in NetBox v4.1.5.

@jeremystretch commented on GitHub (Oct 29, 2024): This has already been addressed in NetBox v4.1.5.
adam commented 2025-12-29 21:31:12 +01:00
Author
Owner
Copy Link

@PieterL75 commented on GitHub (Nov 4, 2024):

Maybe interesting to mention this in the docs, for those who are running Netbox before v4.1.5 ?

@PieterL75 commented on GitHub (Nov 4, 2024): Maybe interesting to mention this in the docs, for those who are running Netbox before v4.1.5 ?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?