starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Update adding-models.md to reflect recent changes to get_absolute_url #10412

New Issue
Closed
opened 2025-12-29 21:31:08 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:31:08 +01:00
Owner
Copy Link

Originally created by @bctiemann on GitHub (Oct 28, 2024).

Originally assigned to: @bctiemann on GitHub.

Proposed Changes

Now that get_absolute_url has been defined in NetBoxFeatureSet, we should update adding-models.md to reflect the recommended pattern (you don't need to add your own method unless nonstandard functionality is needed).

Also add a relevant note about GraphQL unit tests possibly failing when related objects are prefetched.

Justification

The current docs are misleading in the current reality and could lead a developer to add a redundant get_absolute_url method.

Originally created by @bctiemann on GitHub (Oct 28, 2024). Originally assigned to: @bctiemann on GitHub. ### Proposed Changes Now that `get_absolute_url` has been defined in `NetBoxFeatureSet`, we should update adding-models.md to reflect the recommended pattern (you don't need to add your own method unless nonstandard functionality is needed). Also add a relevant note about GraphQL unit tests possibly failing when related objects are prefetched. ### Justification The current docs are misleading in the current reality and could lead a developer to add a redundant `get_absolute_url` method.
adam added the status: acceptedtype: housekeepingnetbox labels 2025-12-29 21:31:08 +01:00
adam closed this issue 2025-12-29 21:31:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10412
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?