starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

In DCIM Device page, saving device information not working #10396

New Issue
Closed
opened 2025-12-29 21:30:54 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:30:54 +01:00
Owner
Copy Link

Originally created by @Xemanth on GitHub (Oct 23, 2024).

Deployment Type

Self-hosted

Triage priority

This is preventing me from using NetBox

NetBox Version

v4.1.4

Python Version

3.12

Steps to Reproduce

  1. Open some DCIM device
  2. Click in the bottom "save"

Expected Behavior

Save button saves the page data

Observed Behavior

Save button doesn't react.

Tested with Firefox and Chrome.
In the organization, site pages saving works, so it's clearly focuses to devices.

Originally created by @Xemanth on GitHub (Oct 23, 2024). ### Deployment Type Self-hosted ### Triage priority This is preventing me from using NetBox ### NetBox Version v4.1.4 ### Python Version 3.12 ### Steps to Reproduce 1. Open some DCIM device 2. Click in the bottom "save" ### Expected Behavior Save button saves the page data ### Observed Behavior Save button doesn't react. Tested with Firefox and Chrome. In the organization, site pages saving works, so it's clearly focuses to devices.
adam added the netbox label 2025-12-29 21:30:54 +01:00
adam closed this issue 2025-12-29 21:30:54 +01:00
adam commented 2025-12-29 21:30:54 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 23, 2024):

Please include more detail about what specifically you're doing, and how someone else can reproduce the problem. Just saving a device works. It's likely you're running into some frontend validation failure.

@jeremystretch commented on GitHub (Oct 23, 2024): Please include more detail about what specifically you're doing, and how someone else can reproduce the problem. Just saving a device works. It's likely you're running into some frontend validation failure.
adam commented 2025-12-29 21:30:55 +01:00
Author
Owner
Copy Link

@Xemanth commented on GitHub (Oct 24, 2024):

Please include more detail about what specifically you're doing, and how someone else can reproduce the problem. Just saving a device work. It's likely you're running into some frontend validation failure.

When I try to edit any field on a device and click save, nothing happens. The service does not save the changes, nor does it show any error message explaining why. The same issue occurs when I try to clone an existing device and save it as a new one. I have filled in all the required fields, but the service still doesn't save the data or provide any feedback.

@Xemanth commented on GitHub (Oct 24, 2024): > Please include more detail about what specifically you're doing, and how someone else can reproduce the problem. Just saving a device work. It's likely you're running into some frontend validation failure. When I try to edit any field on a device and click save, nothing happens. The service does not save the changes, nor does it show any error message explaining why. The same issue occurs when I try to clone an existing device and save it as a new one. I have filled in all the required fields, but the service still doesn't save the data or provide any feedback.
adam commented 2025-12-29 21:30:55 +01:00
Author
Owner
Copy Link

@Xemanth commented on GitHub (Oct 26, 2024):

I cleared my Firefox cache and cookies. Now when I try to save device data I get this kind of server error.
Does this help understanding what might cause this issue?

image

@Xemanth commented on GitHub (Oct 26, 2024): I cleared my Firefox cache and cookies. Now when I try to save device data I get this kind of server error. Does this help understanding what might cause this issue? ![image](https://github.com/user-attachments/assets/339406a9-c6ca-4f2b-b361-c3e527279122)
adam commented 2025-12-29 21:30:56 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 28, 2024):

The validate() method of your custom validator must accept both the instance and request arguments; see the docs for an example. (This was changed in NetBox v4.0 under FR #14279.)

@jeremystretch commented on GitHub (Oct 28, 2024): The `validate()` method of your custom validator must accept both the `instance` and `request` arguments; see [the docs](https://netboxlabs.com/docs/netbox/en/stable/customization/custom-validation/#custom-validation-logic) for an example. (This was changed in NetBox v4.0 under FR #14279.)
adam commented 2025-12-29 21:30:56 +01:00
Author
Owner
Copy Link

@Xemanth commented on GitHub (Oct 28, 2024):

The validate() method of your custom validator must accept both the instance and request arguments; see the docs for an example. (This was changed in NetBox v4.0 under FR #14279.)

Changing the custom validator fixed my issue!
Weird though that it didn't first give any error message until I made full cache wipe :(

@Xemanth commented on GitHub (Oct 28, 2024): > The `validate()` method of your custom validator must accept both the `instance` and `request` arguments; see [the docs](https://netboxlabs.com/docs/netbox/en/stable/customization/custom-validation/#custom-validation-logic) for an example. (This was changed in NetBox v4.0 under FR #14279.) Changing the custom validator fixed my issue! Weird though that it didn't first give any error message until I made full cache wipe :(
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10396
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?