starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Updating an interface via the api and sending lowercase mac_address creates a pointless changelog #10380

New Issue
Closed
opened 2025-12-29 21:30:40 +01:00 by adam · 8 comments
adam commented 2025-12-29 21:30:40 +01:00
Owner
Copy Link

Originally created by @ITJamie on GitHub (Oct 17, 2024).

Originally assigned to: @atownson on GitHub.

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.4

Python Version

3.12

Steps to Reproduce

create an interface on a device. set a mac address.
via the api update the interface with the same mac address but send it in lowercase form instead of uppercase form

Expected Behavior

if the mac addresses match (ignoring case), no changelog should be made

Observed Behavior

a change log is created showing the mac_address being set to lowercase. but its stored in the db in uppercase. so there was no need for the changelog being created

Originally created by @ITJamie on GitHub (Oct 17, 2024). Originally assigned to: @atownson on GitHub. ### Deployment Type Self-hosted ### Triage priority N/A ### NetBox Version v4.1.4 ### Python Version 3.12 ### Steps to Reproduce create an interface on a device. set a mac address. via the api update the interface with the same mac address but send it in lowercase form instead of uppercase form ### Expected Behavior if the mac addresses match (ignoring case), no changelog should be made ### Observed Behavior a change log is created showing the mac_address being set to lowercase. but its stored in the db in uppercase. so there was no need for the changelog being created
adam added the type: bugstatus: acceptednetboxseverity: low labels 2025-12-29 21:30:40 +01:00
adam closed this issue 2025-12-29 21:30:40 +01:00
adam commented 2025-12-29 21:30:41 +01:00
Author
Owner
Copy Link

@ITJamie commented on GitHub (Oct 17, 2024):

Screenshot 2024-10-16 at 20 22 04 Example of the changelog thats created. but viewing the interface directly after this changelog shows that its stored as uppercase
@ITJamie commented on GitHub (Oct 17, 2024): <img width="1010" alt="Screenshot 2024-10-16 at 20 22 04" src="https://github.com/user-attachments/assets/52da1af9-1365-4788-8a27-b83b96ea1ac6"> Example of the changelog thats created. but viewing the interface directly after this changelog shows that its stored as uppercase
adam commented 2025-12-29 21:30:41 +01:00
Author
Owner
Copy Link

@betheapi commented on GitHub (Oct 23, 2024):

I would like to work on this issue

@betheapi commented on GitHub (Oct 23, 2024): I would like to work on this issue
adam commented 2025-12-29 21:30:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 23, 2024):

Thanks @betheapi, I've assigned this to you. For reference, the MAC address should always be normalized to lowercase.

@jeremystretch commented on GitHub (Oct 23, 2024): Thanks @betheapi, I've assigned this to you. For reference, the MAC address should always be normalized to lowercase.
adam commented 2025-12-29 21:30:42 +01:00
Author
Owner
Copy Link

@atownson commented on GitHub (Jan 17, 2025):

I can work on this one.

@atownson commented on GitHub (Jan 17, 2025): I can work on this one.
adam commented 2025-12-29 21:30:42 +01:00
Author
Owner
Copy Link

@atownson commented on GitHub (Jan 17, 2025):

@jeremystretch,
Based on the comment above, MAC Addresses should be normalized to lowercase, correct?
This line normalizes to uppercase:
f845b2cf07/netbox/dcim/fields.py (L43)
I can change this, but wanted to confirm the desired normalization.

@atownson commented on GitHub (Jan 17, 2025): @jeremystretch, Based on the comment above, MAC Addresses should be normalized to lowercase, correct? This line normalizes to uppercase: https://github.com/netbox-community/netbox/blob/f845b2cf07cd65a109c46632a2540d3647c1c492/netbox/dcim/fields.py#L43 I can change this, but wanted to confirm the desired normalization.
adam commented 2025-12-29 21:30:42 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 17, 2025):

I might be wrong then, sorry. Do whatever is most consistent with existing behavior.

@jeremystretch commented on GitHub (Jan 17, 2025): I might be wrong then, sorry. Do whatever is most consistent with existing behavior.
adam commented 2025-12-29 21:30:42 +01:00
Author
Owner
Copy Link

@atownson commented on GitHub (Jan 21, 2025):

Apologies for the back and forth. This issue does not affect NetBox version 4.2 with the new MACAddress model. I've tested patching the MACAddress object itself and the MAC Address associated with a VMInterface with differing variants of the mac_address value and neither results in a change log entry or an update to the object. The mac_address value is always normalized to uppercase using the dialect specification for the MACAddressField. I can look into a fix for the 4.1 version, but suspect a fix would not/could not be merged at this point. If that's not the case please let me know. Otherwise, you may consider marking this as resolved under 4.2.

@atownson commented on GitHub (Jan 21, 2025): Apologies for the back and forth. This issue does not affect NetBox version 4.2 with the new MACAddress model. I've tested patching the MACAddress object itself and the MAC Address associated with a VMInterface with differing variants of the `mac_address` value and neither results in a change log entry or an update to the object. The `mac_address` value is always normalized to uppercase using the `dialect` specification for the `MACAddressField`. I can look into a fix for the 4.1 version, but suspect a fix would not/could not be merged at this point. If that's not the case please let me know. Otherwise, you may consider marking this as resolved under 4.2.
adam commented 2025-12-29 21:30:43 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Jan 21, 2025):

@atownson I agree that makes sense. We ended up going around the issue with the introduction of the new MACAddress model in v4.2. Thanks for digging into it.

I'm going to close this out as resolved.

@jeremystretch commented on GitHub (Jan 21, 2025): @atownson I agree that makes sense. We ended up going around the issue with the introduction of the new MACAddress model in v4.2. Thanks for digging into it. I'm going to close this out as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10380
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?