starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

My CI/CD breaks as Tag v4.1.4 doesn't point to PR merge commit for master branch. It points to commit in develop. #10369

New Issue
Closed
opened 2025-12-29 21:30:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:30:34 +01:00
Owner
Copy Link

Originally created by @marsteel on GitHub (Oct 16, 2024).

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.3

Python Version

3.12

Steps to Reproduce

I have a GitHub workflow in my repo to track NetBox master branch everyday. It checks the tags and find out the latest release by parsing the latest tag. Then I do code review again and merged to my local main branch.

It works well for previous releases. It stopped working with v4.1.4.

          UPSTREAM_TAG=$(git ls-remote --tags | grep -h $(git rev-parse --short ${{ env.upstream_remote_name }}/${{ env.upstream_branch_name }} ) | awk 'END{print}' | awk '{print $2}' | cut -d'/' -f 3)
          UPSTREAM_HEAD_COMMIT=$(git rev-parse --short ${{ env.upstream_remote_name }}/${{ env.upstream_branch_name }} )

The tag for latest version v4.1.4 doesn't point the commit of "Merge pull request" in master branch. Or the latest commit in master branch is not in the repo tag list. There is inconsistence.

With git ls-remote --tags or git ls-remote --tags https://github.com/netbox-community/netbox.git the tags can be feteched.
The tag v4.1.4 points to d2cbdfe7d7 in develop branch
While other tags pointed to "Merge pull request" in master branch.

Tag v4.1.4 should point to 6ea0c0c in master branch

7bc0d34196323ac992d7ec80b1caa48e6094d88d        refs/tags/v4.1.0
Merge pull request #17350 from netbox-community/develop                 <--- commit in master branch
0e34fba92223348e0bf4375b8d380324ff5e1beb        refs/tags/v4.1.1
Merge pull request #17478 from netbox-community/develop                 <--- commit in master branch
ead6e637f4aecc4717b10c71f9140c94040da264        refs/tags/v4.1.2
Merge pull request #17626 from netbox-community/develop                 <--- commit in master branch
6ea0c0c3e910d1104fd0fbe5e6cd07198862d1fa        refs/tags/v4.1.3
Merge pull request #17658 from netbox-community/develop                 <--- commit in master branch
d2cbdfe7d742f0d2db7989ed27cde466c8366dea        refs/tags/v4.1.4
Release v4.1.4                                            <--- commit in develop branch

Expected Behavior

Tag v4.1.4 should point to 6ea0c0c in master branch

Observed Behavior

Tag v4.1.4 points to d2cbdfe7d7 in develop branch

Originally created by @marsteel on GitHub (Oct 16, 2024). ### Deployment Type Self-hosted ### Triage priority N/A ### NetBox Version v4.1.3 ### Python Version 3.12 ### Steps to Reproduce I have a GitHub workflow in my repo to track NetBox master branch everyday. It checks the tags and find out the latest release by parsing the latest tag. Then I do code review again and merged to my local main branch. It works well for previous releases. It stopped working with v4.1.4. ``` UPSTREAM_TAG=$(git ls-remote --tags | grep -h $(git rev-parse --short ${{ env.upstream_remote_name }}/${{ env.upstream_branch_name }} ) | awk 'END{print}' | awk '{print $2}' | cut -d'/' -f 3) UPSTREAM_HEAD_COMMIT=$(git rev-parse --short ${{ env.upstream_remote_name }}/${{ env.upstream_branch_name }} ) ``` The tag for latest version v4.1.4 doesn't point the commit of "Merge pull request" in master branch. Or the latest commit in master branch is not in the repo tag list. There is inconsistence. With `git ls-remote --tags` or `git ls-remote --tags https://github.com/netbox-community/netbox.git` the tags can be feteched. The tag v4.1.4 points to d2cbdfe7d742f0d2db7989ed27cde466c8366dea in develop branch While other tags pointed to "Merge pull request" in master branch. Tag v4.1.4 should point to 6ea0c0c in master branch ``` 7bc0d34196323ac992d7ec80b1caa48e6094d88d refs/tags/v4.1.0 Merge pull request #17350 from netbox-community/develop <--- commit in master branch 0e34fba92223348e0bf4375b8d380324ff5e1beb refs/tags/v4.1.1 Merge pull request #17478 from netbox-community/develop <--- commit in master branch ead6e637f4aecc4717b10c71f9140c94040da264 refs/tags/v4.1.2 Merge pull request #17626 from netbox-community/develop <--- commit in master branch 6ea0c0c3e910d1104fd0fbe5e6cd07198862d1fa refs/tags/v4.1.3 Merge pull request #17658 from netbox-community/develop <--- commit in master branch d2cbdfe7d742f0d2db7989ed27cde466c8366dea refs/tags/v4.1.4 Release v4.1.4 <--- commit in develop branch ``` ### Expected Behavior Tag v4.1.4 should point to 6ea0c0c in master branch ### Observed Behavior Tag v4.1.4 points to d2cbdfe7d742f0d2db7989ed27cde466c8366dea in develop branch
adam closed this issue 2025-12-29 21:30:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?