starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

BulkImport naming inconsistency #10362

New Issue
Closed
opened 2025-12-29 21:30:28 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:30:28 +01:00
Owner
Copy Link

Originally created by @wkoot on GitHub (Oct 14, 2024).

Originally assigned to: @jeremystretch on GitHub.

Proposed Changes

Either rename views.generic.BulkImportView to views.generic.ImportView, or alter the urlpatterns to name='*_bulk_import'.
For backwards compatability, the BulkView could be an alias or urlpattern name='*_import' could be supported until a next major release.

I believe that renaming the urlpattern is better, since an import action could add only a single object (i.e. with a plugin connecting to an external service).
In this case, the NetBoxModelImportForm should probably also be renamed to NetBoxModelBulkImportForm.

Justification

The current implementation is inconsistent; the other bulk urlpatterns are named _bulk_add, _bulk_edit, _bulk_rename and _bulk_delete.
See for instance netbox/dcim/urls.py and netbox/ipam/urls.py.

Originally created by @wkoot on GitHub (Oct 14, 2024). Originally assigned to: @jeremystretch on GitHub. ### Proposed Changes Either rename `views.generic.BulkImportView` to `views.generic.ImportView`, or alter the urlpatterns to `name='*_bulk_import'`. For backwards compatability, the `BulkView` could be an alias or urlpattern `name='*_import'` could be supported until a next major release. I believe that renaming the urlpattern is better, since an import action could add only a single object (i.e. with a plugin connecting to an external service). In this case, the `NetBoxModelImportForm` should probably also be renamed to `NetBoxModelBulkImportForm`. ### Justification The current implementation is inconsistent; the other bulk urlpatterns are named `_bulk_add`, `_bulk_edit`, `_bulk_rename` and `_bulk_delete`. See for instance `netbox/dcim/urls.py` and `netbox/ipam/urls.py`.
adam added the status: acceptedtype: housekeepingnetbox labels 2025-12-29 21:30:28 +01:00
adam closed this issue 2025-12-29 21:30:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox status: accepted type: housekeeping
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10362
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?