starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

image-attachments upload does not sanitize . (dot) in filename and file suffix missing #10356

New Issue
Closed
opened 2025-12-29 21:30:25 +01:00 by adam · 3 comments
adam commented 2025-12-29 21:30:25 +01:00
Owner
Copy Link

Originally created by @ypid on GitHub (Oct 11, 2024).

Originally assigned to: @bctiemann on GitHub.

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.3

Python Version

3.10

Steps to Reproduce

  1. Upload webp image on https://demo.netbox.dev/extras/image-attachments/add/?object_type=60&object_id=1 and name it "Test image that contains . dot".

Expected Behavior

Image should be saved as https://demo.netbox.dev/media/image-attachments/module_type_1_Test_image_that_contains___dot.webp

Observed Behavior

Image was saved as https://demo.netbox.dev/media/image-attachments/module_type_1_Test_image_that_contains_._dot

Originally created by @ypid on GitHub (Oct 11, 2024). Originally assigned to: @bctiemann on GitHub. ### Deployment Type Self-hosted ### Triage priority N/A ### NetBox Version v4.1.3 ### Python Version 3.10 ### Steps to Reproduce 1. Upload webp image on https://demo.netbox.dev/extras/image-attachments/add/?object_type=60&object_id=1 and name it "Test image that contains . dot". ### Expected Behavior Image should be saved as https://demo.netbox.dev/media/image-attachments/module_type_1_Test_image_that_contains___dot.webp ### Observed Behavior Image was saved as https://demo.netbox.dev/media/image-attachments/module_type_1_Test_image_that_contains_._dot
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:30:25 +01:00
adam closed this issue 2025-12-29 21:30:25 +01:00
adam commented 2025-12-29 21:30:25 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Oct 11, 2024):

@ypid I get the file suffix and it seems to work with the extra dot, are you seeing a specific issue when it has the extra dot?

@arthanson commented on GitHub (Oct 11, 2024): @ypid I get the file suffix and it seems to work with the extra dot, are you seeing a specific issue when it has the extra dot?
adam commented 2025-12-29 21:30:26 +01:00
Author
Owner
Copy Link

@ypid commented on GitHub (Oct 11, 2024):

@arthanson You are not able to reproduce this? I am testing with Firefox 128.3.1esr (64-bit) against https://demo.netbox.dev
How is the file called for you? Is the dot in the middle of the file name sanitized for you?

@ypid commented on GitHub (Oct 11, 2024): @arthanson You are not able to reproduce this? I am testing with Firefox 128.3.1esr (64-bit) against https://demo.netbox.dev How is the file called for you? Is the dot in the middle of the file name sanitized for you?
adam commented 2025-12-29 21:30:26 +01:00
Author
Owner
Copy Link

@ypid commented on GitHub (Oct 12, 2024):

I retested it. When you upload a PNG file test.png, the file suffix .png is added to the sanitized name and used as filename.

For webp, it is not added. So when you download this image, you will have a file called module_type_1_Test_image_that_contains_._dot on your filesystem. By convention, the filetype should be in the end of the filename.

@ypid commented on GitHub (Oct 12, 2024): I retested it. When you upload a PNG file `test.png`, the file suffix `.png` is added to the sanitized name and used as filename. For webp, it is not added. So when you download this image, you will have a file called `module_type_1_Test_image_that_contains_._dot` on your filesystem. By convention, the filetype should be in the end of the filename.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10356
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?