starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Job.clean() not called #10324

New Issue
Closed
opened 2025-12-29 21:29:59 +01:00 by adam · 8 comments
adam commented 2025-12-29 21:29:59 +01:00
Owner
Copy Link

Originally created by @alehaa on GitHub (Oct 7, 2024).

Originally assigned to: @alehaa on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.1.3

Python Version

3.11

Steps to Reproduce

  1. Create a new JobRunner.
  2. Schedule the job runner without with enqueue(interval=0).

Expected Behavior

Getting a ValidationError:

django.core.exceptions.ValidationError: {
  '__all__': [
    'Jobs cannot be assigned to this object type (None).'
  ]
}

Observed Behavior

Nothing happens, as neither Job.enqueue(), Job.start() nor Job.terminate() trigger Job.clean().

Originally created by @alehaa on GitHub (Oct 7, 2024). Originally assigned to: @alehaa on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.1.3 ### Python Version 3.11 ### Steps to Reproduce 1. Create a new `JobRunner`. 2. Schedule the job runner without with `enqueue(interval=0)`. ### Expected Behavior Getting a `ValidationError`: ```Python django.core.exceptions.ValidationError: { '__all__': [ 'Jobs cannot be assigned to this object type (None).' ] } ``` ### Observed Behavior Nothing happens, as neither `Job.enqueue()`, `Job.start()` nor `Job.terminate()` trigger `Job.clean()`.
adam added the type: bugstatus: acceptednetboxseverity: low labels 2025-12-29 21:29:59 +01:00
adam closed this issue 2025-12-29 21:29:59 +01:00
adam commented 2025-12-29 21:30:00 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Oct 7, 2024):

This error occured during testing of similar issues, as Job.clean() (like #17682, #17086 and #17648) assumes the object_type field is not None. If its decided Job should call clean(), this should be fixed as well (could happen in conjunction with #17682). Otherwise the method could be removed IMHO.

@alehaa commented on GitHub (Oct 7, 2024): This error occured during testing of similar issues, as `Job.clean()` (like #17682, #17086 and #17648) assumes the `object_type` field is not `None`. If its decided `Job` should call `clean()`, this should be fixed as well (could happen in conjunction with #17682). Otherwise the method could be removed IMHO.
adam commented 2025-12-29 21:30:00 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 7, 2024):

@alehaa could you please elaborate on your steps to reproduce above? It is not clear exactly what you're doing. Example code would be helpful.

@jeremystretch commented on GitHub (Oct 7, 2024): @alehaa could you please elaborate on your steps to reproduce above? It is not clear exactly what you're doing. Example code would be helpful.
adam commented 2025-12-29 21:30:00 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Oct 7, 2024):

During the implementation of #16971, I tested whether NetBox would raise exceptions on incorrectly configured jobs, and whether separate tests needed to be added to the system job registration. I added this (abbreviated) code to NetBox:

class SampleJob(JobRunner):
    def run(self, *args, **kwargs):
        pass

SampleJob.enqueue_once(interval=0)

The job can be scheduled without error. However, this should fail for two reasons:

  1. interval=0 violates the field's MinValueValidator(1).
  2. As no instance is set, clean() would raise an exception as it doesn't take into account self.object_type can be None. That's a bug related to #17682, #17086 and #17648, but didn't attract attention before, as clean() isn't called by any of the other methods in Job.

As this is not a cause of system jobs (#16971), but the Job model itself, I see this as a separate issue / bug.

@alehaa commented on GitHub (Oct 7, 2024): During the implementation of #16971, I tested whether NetBox would raise exceptions on incorrectly configured jobs, and whether separate tests needed to be added to the system job registration. I added this (abbreviated) code to NetBox: ```Python class SampleJob(JobRunner): def run(self, *args, **kwargs): pass SampleJob.enqueue_once(interval=0) ``` The job can be scheduled without error. However, this should fail for two reasons: 1. `interval=0` violates the field's `MinValueValidator(1)`. 2. As no instance is set, `clean()` would raise an exception as it doesn't take into account `self.object_type` can be `None`. That's a bug related to #17682, #17086 and #17648, but didn't attract attention before, as `clean()` isn't called by any of the other methods in `Job`. As this is not a cause of system jobs (#16971), but the `Job` model itself, I see this as a separate issue / bug.
adam commented 2025-12-29 21:30:01 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Oct 15, 2024):

This is a reminder that additional information is needed in order to further triage this issue. If the requested details are not provided, the issue will soon be closed automatically.

@github-actions[bot] commented on GitHub (Oct 15, 2024): This is a reminder that additional information is needed in order to further triage this issue. If the requested details are not provided, the issue will soon be closed automatically.
adam commented 2025-12-29 21:30:01 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Oct 15, 2024):

@jeremystretch Did you have a chance to review the additional information above?

@alehaa commented on GitHub (Oct 15, 2024): @jeremystretch Did you have a chance to review the additional information above?
adam commented 2025-12-29 21:30:01 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 22, 2024):

@alehaa pk, I'll flag this for an owner, unless you'd like to take it?

@jeremystretch commented on GitHub (Oct 22, 2024): @alehaa pk, I'll flag this for an owner, unless you'd like to take it?
adam commented 2025-12-29 21:30:02 +01:00
Author
Owner
Copy Link

@alehaa commented on GitHub (Oct 22, 2024):

I can provide a PR. As this is a fix for existing functionality I assume develop is the right branch?

@alehaa commented on GitHub (Oct 22, 2024): I can provide a PR. As this is a fix for existing functionality I assume `develop` is the right branch?
adam commented 2025-12-29 21:30:02 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Oct 22, 2024):

@alehaa great, thanks! And yeah, develop please.

@jeremystretch commented on GitHub (Oct 22, 2024): @alehaa great, thanks! And yeah, `develop` please.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label netbox severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?