starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Report raises AbortTransaction() when commit=False and log_failure() has been used #10300

New Issue
Closed
opened 2025-12-29 21:29:36 +01:00 by adam · 0 comments
adam commented 2025-12-29 21:29:36 +01:00
Owner
Copy Link

Originally created by @craized on GitHub (Sep 27, 2024).

Originally assigned to: @arthanson on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.1.2

Python Version

3.11

Steps to Reproduce

Create a script that logs a failure. Run the script with commit=False

from extras.scripts import Script

class LogFailure(Script):
  description = "Log one failure"

  def test_error_behavior(self):
    self.log_failure("This is a test failure, not a script failure")

Expected Behavior

The script will log one 'Failure' line, rollback database changes, and complete

Observed Behavior

The script logs appropriate, but adds an additional failure, as show below, before rolling back DB changes

An exception occurred: AbortTransaction:

Traceback (most recent call last):
  File "/opt/netbox/netbox/extras/jobs.py", line 47, in run_script
    raise AbortTransaction()
utilities.exceptions.AbortTransaction
Originally created by @craized on GitHub (Sep 27, 2024). Originally assigned to: @arthanson on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.1.2 ### Python Version 3.11 ### Steps to Reproduce Create a script that logs a failure. Run the script with commit=False ``` from extras.scripts import Script class LogFailure(Script): description = "Log one failure" def test_error_behavior(self): self.log_failure("This is a test failure, not a script failure") ``` ### Expected Behavior The script will log one 'Failure' line, rollback database changes, and complete ### Observed Behavior The script logs appropriate, but adds an additional failure, as show below, before rolling back DB changes ``` An exception occurred: AbortTransaction: Traceback (most recent call last): File "/opt/netbox/netbox/extras/jobs.py", line 47, in run_script raise AbortTransaction() utilities.exceptions.AbortTransaction ```
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:29:36 +01:00
adam closed this issue 2025-12-29 21:29:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?