starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

change rack dimensions from integer to decimal #10253

New Issue
Closed
opened 2025-12-29 21:28:59 +01:00 by adam · 5 comments
adam commented 2025-12-29 21:28:59 +01:00
Owner
Copy Link

Originally created by @ghost on GitHub (Sep 17, 2024).

NetBox version

v4.1.1

Feature type

Change to existing functionality

Proposed functionality

please change rack dimensions from integer to decimal.

Use case

as odd as it sounds, we have encountered a rack that is 29.5 inches wide. not 29, not 30, 29.5.

image

Database changes

change rack type outer dimensions "outer width", "outer depth", and "max weight" from int to decimal.

External dependencies

none

Originally created by @ghost on GitHub (Sep 17, 2024). ### NetBox version v4.1.1 ### Feature type Change to existing functionality ### Proposed functionality please change rack dimensions from integer to decimal. ### Use case as odd as it sounds, we have encountered a rack that is 29.5 inches wide. not 29, not 30, 29.5. ![image](https://github.com/user-attachments/assets/28723ba9-d200-4a4c-9c05-9af11c88283e) ### Database changes change rack type outer dimensions "outer width", "outer depth", and "max weight" from **int** to **decimal**. ### External dependencies none
adam added the type: featurepending closurenetboxneeds milestonecomplexity: low labels 2025-12-29 21:28:59 +01:00
adam closed this issue 2025-12-29 21:29:00 +01:00
adam commented 2025-12-29 21:29:00 +01:00
Author
Owner
Copy Link

@bctiemann commented on GitHub (Sep 18, 2024):

I'd say a Decimal makes more sense here (and would be more consistent with existing fields on other models).

@bctiemann commented on GitHub (Sep 18, 2024): I'd say a Decimal makes more sense here (and would be more consistent with existing fields on other models).
adam commented 2025-12-29 21:29:01 +01:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 18, 2024):

I'd say a Decimal makes more sense here (and would be more consistent with existing fields on other models).

that works too. sorry, my quick google search on what kind of programmatic number would support non-whole numbers said floating.
I've edited the FR to reflect decimal.

@ghost commented on GitHub (Sep 18, 2024): > I'd say a Decimal makes more sense here (and would be more consistent with existing fields on other models). that works too. sorry, my quick google search on what kind of programmatic number would support non-whole numbers said floating. I've edited the FR to reflect decimal.
adam commented 2025-12-29 21:29:01 +01:00
Author
Owner
Copy Link

@jeremystretch commented on GitHub (Sep 18, 2024):

This would be a breaking change and must be implemented in a minor release.

@jeremystretch commented on GitHub (Sep 18, 2024): This would be a breaking change and must be implemented in a minor release.
adam commented 2025-12-29 21:29:01 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Apr 25, 2025):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions[bot] commented on GitHub (Apr 25, 2025): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. **Do not** attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our [contributing guide](https://github.com/netbox-community/netbox/blob/main/CONTRIBUTING.md).
adam commented 2025-12-29 21:29:01 +01:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (May 25, 2025):

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

@github-actions[bot] commented on GitHub (May 25, 2025): This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label complexity: low needs milestone netbox pending closure type: feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?