starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Strawberry debug toolbar must not be enabled in non-debug mode #10201

New Issue
Closed
opened 2025-12-29 21:28:15 +01:00 by adam · 2 comments
adam commented 2025-12-29 21:28:15 +01:00
Owner
Copy Link

Originally created by @abhi1693 on GitHub (Sep 8, 2024).

Originally assigned to: @arthanson on GitHub.

Deployment Type

Self-hosted

NetBox Version

v4.1.0

Python Version

3.12

Steps to Reproduce

Go to settings.py and notice that strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware is in the middleware always enabled

Expected Behavior

strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware must only be enabled in debug mode

Observed Behavior

strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware is called during every request to netbox

Originally created by @abhi1693 on GitHub (Sep 8, 2024). Originally assigned to: @arthanson on GitHub. ### Deployment Type Self-hosted ### NetBox Version v4.1.0 ### Python Version 3.12 ### Steps to Reproduce Go to `settings.py` and notice that `strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware` is in the `middleware` always enabled ### Expected Behavior `strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware` must only be enabled in `debug` mode ### Observed Behavior `strawberry_django.middlewares.debug_toolbar.DebugToolbarMiddleware` is called during every request to netbox
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:28:15 +01:00
adam closed this issue 2025-12-29 21:28:15 +01:00
adam commented 2025-12-29 21:28:15 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Sep 9, 2024):

@abhi1693 were you actually seeing this causing issues? The debug toolbar (non strawberry) can be installed by default as it checks internally if DEBUG is set. Curious what issues strawberry one is causing in non debug mode?

@arthanson commented on GitHub (Sep 9, 2024): @abhi1693 were you actually seeing this causing issues? The debug toolbar (non strawberry) can be installed by default as it checks internally if DEBUG is set. Curious what issues strawberry one is causing in non debug mode?
adam commented 2025-12-29 21:28:16 +01:00
Author
Owner
Copy Link

@abhi1693 commented on GitHub (Sep 9, 2024):

Even when the requests are from the rest API endpoint, our APM data shows it originated from strawberry django which makes it difficult to troubleshoot as we don't even use graphql in our integrations

@abhi1693 commented on GitHub (Sep 9, 2024): Even when the requests are from the rest API endpoint, our APM data shows it originated from strawberry django which makes it difficult to troubleshoot as we don't even use graphql in our integrations
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?