starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Default class custom links invisible in dark mode #10104

New Issue
Closed
opened 2025-12-29 21:26:53 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:26:53 +01:00
Owner
Copy Link

Originally created by @llamafilm on GitHub (Aug 16, 2024).

Originally assigned to: @arthanson on GitHub.

Deployment Type

NetBox Enterprise

NetBox Version

v4.0.8

Python Version

3.12

Steps to Reproduce

  1. Create a working custom link
  2. Enable dark mode

Expected Behavior

Button should be visible

Observed Behavior

Button is invisible until you mouse over.
mouseover: Screenshot 2024-08-15 at 10 50 07 PM
regular: Screenshot 2024-08-15 at 10 50 03 PM

A similar bug was fixed in #15616 but for some reason it only fixes non-working links. Working links are still invisible.

Originally created by @llamafilm on GitHub (Aug 16, 2024). Originally assigned to: @arthanson on GitHub. ### Deployment Type NetBox Enterprise ### NetBox Version v4.0.8 ### Python Version 3.12 ### Steps to Reproduce 1. Create a working custom link 2. Enable dark mode ### Expected Behavior Button should be visible ### Observed Behavior Button is invisible until you mouse over. mouseover: <img width="85" alt="Screenshot 2024-08-15 at 10 50 07 PM" src="https://github.com/user-attachments/assets/b0f79530-cba5-461d-9c90-876a8c3719ea"> regular: <img width="104" alt="Screenshot 2024-08-15 at 10 50 03 PM" src="https://github.com/user-attachments/assets/2f1d6152-f9ed-400a-a100-11b4467a3422"> A similar bug was fixed in #15616 but for some reason it only fixes non-working links. Working links are still invisible.
adam added the type: bugstatus: acceptedseverity: low labels 2025-12-29 21:26:53 +01:00
adam closed this issue 2025-12-29 21:26:53 +01:00
adam commented 2025-12-29 21:26:55 +01:00
Author
Owner
Copy Link

@arthanson commented on GitHub (Aug 16, 2024):

Issue is here https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/choices.py#L87 as btn-outline-dark is not visible in dark-mode. However this would require a migration to change the values as the choice is stored in the DB, there are also a lot of references to btn-outline-dark in https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/tables/template_code.py and https://github.com/netbox-community/netbox/blob/develop/netbox/templates/extras/inc/format_toggle.html which should probably be changes to btn-outline-secondary.

@arthanson commented on GitHub (Aug 16, 2024): Issue is here https://github.com/netbox-community/netbox/blob/develop/netbox/netbox/choices.py#L87 as btn-outline-dark is not visible in dark-mode. However this would require a migration to change the values as the choice is stored in the DB, there are also a lot of references to btn-outline-dark in https://github.com/netbox-community/netbox/blob/develop/netbox/dcim/tables/template_code.py and https://github.com/netbox-community/netbox/blob/develop/netbox/templates/extras/inc/format_toggle.html which should probably be changes to btn-outline-secondary.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label severity: low status: accepted type: bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?