starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Include TPID in VLAN model #10031

New Issue
Closed
opened 2025-12-29 21:25:58 +01:00 by adam · 1 comment
adam commented 2025-12-29 21:25:58 +01:00
Owner
Copy Link

Originally created by @movedempackets on GitHub (Jul 31, 2024).

NetBox version

v4.0.8

Feature type

Data model extension

Proposed functionality

The VLAN model does not include the tag protocol ID (TPID) field. The TPID value can be used to distinguish tagged frames (for example a TPID: 0x8100 VID: 1 tagged frame is not equal to a TPID: 0x88a8 VID: 1 tagged frame).

It's unsuitable for Administrators to apply a TPID custom field to the VLAN model. When a VLAN belongs to a group it's constrained by "ipam_vlan_unique_group_vid" UNIQUE CONSTRAINT, btree (group_id, vid). Therefore VLAN's of equal VID but of unequal TPID cannot be contained in the same group.

I propose that the VLAN model include the TPID field, which can be a choice of valid TPID values. I can contribute to the implementation of this feature, if accepted.

Use case

Users can now specify the VLAN TPID value.

Database changes

The ipam_vlan table should include a new column named tpid. The ipam_vlan_unique_group_vid unique constraint should include the tpid column.

External dependencies

No response

Originally created by @movedempackets on GitHub (Jul 31, 2024). ### NetBox version v4.0.8 ### Feature type Data model extension ### Proposed functionality The VLAN model does not include the tag protocol ID (TPID) field. The TPID value can be used to distinguish tagged frames (for example a TPID: 0x8100 VID: 1 tagged frame is not equal to a TPID: 0x88a8 VID: 1 tagged frame). > It's unsuitable for Administrators to apply a TPID custom field to the VLAN model. When a VLAN belongs to a group it's constrained by "ipam_vlan_unique_group_vid" UNIQUE CONSTRAINT, btree (group_id, vid). Therefore VLAN's of equal VID but of unequal TPID cannot be contained in the same group. I propose that the VLAN model include the TPID field, which can be a choice of valid TPID values. I can contribute to the implementation of this feature, if accepted. ### Use case Users can now specify the VLAN TPID value. ### Database changes The `ipam_vlan` table should include a new column named `tpid`. The `ipam_vlan_unique_group_vid` unique constraint should include the `tpid` column. ### External dependencies _No response_
adam closed this issue 2025-12-29 21:25:58 +01:00
adam commented 2025-12-29 21:25:59 +01:00
Author
Owner
Copy Link

@DanSheps commented on GitHub (Sep 19, 2024):

After discussing and reviewing this with other maintainers, there appears to be a lot of overlap with #13428 and we should proceed with all work under that FR.

@DanSheps commented on GitHub (Sep 19, 2024): After discussing and reviewing this with other maintainers, there appears to be a lot of overlap with #13428 and we should proceed with all work under that FR.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#10031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?