starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-04-17 06:29:53 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Merge pull request #21065 from netbox-community/21049-clean-stale-cf-data

Browse Source 
Fixes #21049: Remove stale custom field data during object validation
This commit is contained in:
bctiemann
2026-01-05 20:19:46 -05:00
committed by GitHub
parent 5a64cb712d 6ed6da49d9
commit f903442cb9
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
netbox/extras/tests/test_customfields.py
View File

@@ -1506,19 +1506,18 @@ class CustomFieldModelTest(TestCase):
def test_invalid_data(self):
"""
Setting custom field data for a non-applicable (or non-existent) CustomField should raise a ValidationError.
Any invalid or stale custom field data should be removed from the instance.
"""
site = Site(name='Test Site', slug='test-site')
# Set custom field data
site.custom_field_data['foo'] = 'abc'
site.custom_field_data['bar'] = 'def'
with self.assertRaises(ValidationError):
site.clean()
del site.custom_field_data['bar']
site.clean()
self.assertIn('foo', site.custom_field_data)
self.assertNotIn('bar', site.custom_field_data)
def test_missing_required_field(self):
"""
Check that a ValidationError is raised if any required custom fields are not present.