starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-04-22 16:58:49 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

fix(ipam): Use bulk_update in VLANGroup VID range migration

Browse Source 
Replace per-row `save()` calls with `bulk_update` when populating
VLANGroup VLAN ID ranges during migration.

This avoids triggering post_save handlers (e.g. search cache/indexing)
on existing VLANGroup records and updates only the relevant fields,
improving both reliability and performance on larger databases.

Fixes #21375
This commit is contained in:
Martin Hauser
2026-02-06 19:52:16 +01:00
committed by Jeremy Stretch
parent ae736ef407
commit f4c27fd494
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
netbox/ipam/migrations/0070_vlangroup_vlan_id_ranges.py
View File

@@ -13,10 +13,11 @@ def set_vid_ranges(apps, schema_editor):
VLANGroup = apps.get_model('ipam', 'VLANGroup') VLANGroup = apps.get_model('ipam', 'VLANGroup')
db_alias = schema_editor.connection.alias db_alias = schema_editor.connection.alias
for group in VLANGroup.objects.using(db_alias).all(): vlan_groups = VLANGroup.objects.using(db_alias).only('id', 'min_vid', 'max_vid')
for group in vlan_groups:
group.vid_ranges = [NumericRange(group.min_vid, group.max_vid, bounds='[]')] group.vid_ranges = [NumericRange(group.min_vid, group.max_vid, bounds='[]')]
group._total_vlan_ids = group.max_vid - group.min_vid + 1 group._total_vlan_ids = group.max_vid - group.min_vid + 1
group.save() VLANGroup.objects.using(db_alias).bulk_update(vlan_groups, ['vid_ranges', '_total_vlan_ids'], batch_size=100)
class Migration(migrations.Migration): class Migration(migrations.Migration):