starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-04-11 03:37:06 +02:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

Enforce custom field validation on the model

Browse Source
This commit is contained in:
Jeremy Stretch
2020-11-12 14:23:08 -05:00
parent 4a8a1ce45c
commit f3f3993963
3 changed files with 83 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
netbox/extras/tests/test_customfields.py
View File

@@ -550,6 +550,10 @@ class CustomFieldModelTest(TestCase):
cf2.content_types.set([ContentType.objects.get_for_model(Rack)])
def test_cf_data(self):
"""
Check that custom field data is present on the instance immediately after being set and after being fetched
from the database.
"""
site = Site(name='Test Site', slug='test-site')
# Check custom field data on new instance
@@ -570,9 +574,26 @@ class CustomFieldModelTest(TestCase):
# Set custom field data
site.cf['foo'] = 'abc'
site.cf['bar'] = 'def'
with self.assertRaises(ValidationError):
site.clean()
del(site.cf['bar'])
site.clean()
def test_missing_required_field(self):
"""
Check that a ValidationError is raised if any required custom fields are not present.
"""
cf3 = CustomField(type=CustomFieldTypeChoices.TYPE_TEXT, name='baz', required=True)
cf3.save()
cf3.content_types.set([ContentType.objects.get_for_model(Site)])
site = Site(name='Test Site', slug='test-site')
# Set custom field data with a required field omitted
site.cf['foo'] = 'abc'
with self.assertRaises(ValidationError):
site.clean()
site.cf['baz'] = 'def'
site.clean()